kops_cluster_updater: add instance group filtering to rolling updates #1114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds `instance_groups` attribute to `rolling_update_options` that if set only runs the rolling update on the specified IGs. Equivalent to running `kops rolling-update cluster --instance-groups=<ig1>,<ig2>,... --yes`
|
@eddycharly any chance I could get a review? This functionality is the last missing piece in migrating management of our 11 kops clusters into Terraform. Otherwise we will have to run |
|
Ahh, I see you have moved on from supporting the kops provider. I will close this MR and open it with the new provider |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
instance_groupsattribute torolling_update_optionsthat, if set, only runs the rolling update on the specified IGs.Equivalent to running
kops rolling-update cluster --instance-groups=<ig1>,<ig2>,... --yesCloses #1113