Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sentry-sdk requirement from <2.0,>=1.0.0 to >=2.7.1,<3.0 #177

Closed
wants to merge 1 commit into from
Closed

Update sentry-sdk requirement from <2.0,>=1.0.0 to >=2.7.1,<3.0 #177

wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 1, 2024

Updates the requirements on sentry-sdk to permit the latest version.

Release notes

Sourced from sentry-sdk's releases.

2.7.1

Various fixes & improvements

Changelog

Sourced from sentry-sdk's changelog.

2.7.1

Various fixes & improvements

2.7.0

2.6.0

2.5.1

... (truncated)

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot
Update sentry-sdk requirement from <2.0,>=1.0.0 to >=2.7.1,<3.0
6cd1321 
Updates the requirements on [sentry-sdk](https://github.com/getsentry/sentry-python) to permit the latest version.
- [Release notes](https://github.com/getsentry/sentry-python/releases)
- [Changelog](https://github.com/getsentry/sentry-python/blob/master/CHANGELOG.md)
- [Commits](getsentry/sentry-python@v1.0...2.7.1)

---
updated-dependencies:
- dependency-name: sentry-sdk
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jul 1, 2024
@dependabot dependabot bot mentioned this pull request Jul 1, 2024
Closed
@Mr0grog
Copy link
Member

Mr0grog commented Jul 1, 2024

See notes from #173:

Putting this on ice for now, but once I get around to solving some other actual-release-related issues (e.g. #145, #165) this is worth coming back to.

From the release notes and migration guide, it looks like there are some changes that need some deeper examination and testing. We probably also want to just upgrade to sentry-sdk >=2.0.0,<3.0. I think that’s ok since this only applies to the server, which is generally meant to run as a standalone app, rather than be used as a library.

  • Scopes now fork instead of stack. push_scope() (which we use) is deprecated, and I’m worried some behaviors we do will no longer work correctly: inside the with block, we set some things directly on the new scope, and some through the top-level SDK methods (actually I’m surprised this currently works, and don’t recall how we got to this state of affairs, even though it is probably my doing; it seems weird).

  • The Tornado integration requires Python 3.8+ and we currently support v3.7. (We don’t configure Sentry in CI, so we may not be seeing problems we would in production, or things are breaking silently.)

  • I believe the Internet Archive uses this server in conjunction with self-hosted Sentry, and v2 of the SDK is only compatible with Sentry server v20.6.0+. We need to check with them about changes here. (https://docs.sentry.io/platforms/python/migration/1.x-to-2.x#self-hosted)

@Mr0grog Mr0grog marked this pull request as draft July 1, 2024 15:45
@dependabot Dependabot
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 1, 2024

Superseded by #179.

@dependabot dependabot bot closed this Aug 1, 2024
@dependabot dependabot bot deleted the dependabot/pip/sentry-sdk-gte-2.7.1-and-lt-3.0 branch August 1, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Mr0grog