-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Lotería (Spanish Lottery) #360
Conversation
@edm00se |
The linter is complaining about a dead url, which does not appear to be accurate. The preview build by vercel failed to run because with the higher volume of people contributing this month, we’ve exceeded my free account’s build limit. I believe that should be cleared within 24 hours. As for the lint action, a re-run didn’t fix it, so I’ll have a look later this evening. Thanks. |
@edm00se |
@edm00se |
I'm looking into the linter, which is giving us the false positive on the dead url check. @tvermaashutosh I suspect the lint checking rule is having an issue with the link containing the accented character. This shouldn't be the case, utf8 encoding takes care of most of this silliness, but here we are. There appears to be an open issue from the source of the rule. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, to get around this, please update the game link to use the Board Game Geek link and see if that fixes it; I believe this to be the same game. If the image url has the same issue, it would need to be changed as well.
Ok @edm00se lemme do these changes and make new commits. |
@edm00se |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Things are looking good! Thank you for contributing.
refs #269
Submitting this PR means you have:
Once your PR is created, it will trigger a build a GitHub Action (Awesome-Lint). This includes a format linting process, so if there are any issues with the build, please address them.
Do you have further questions? Check the contribution guidelines or open an issue.
When you're ready, check off the above acknowledgements and continue with your Pull Request... and thanks!