Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Lotería (Spanish Lottery) #360

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Added Lotería (Spanish Lottery) #360

merged 2 commits into from
Oct 17, 2023

Conversation

tvermaashutosh
Copy link
Contributor

@tvermaashutosh tvermaashutosh commented Oct 14, 2023

Submitting this PR means you have:

  • searched the readme file and searched the open pull requests (no duplicates please)
  • and will follow the desired format
  • used image links that resolve correctly, are appropriately sized, and are served over HTTPS

Once your PR is created, it will trigger a build a GitHub Action (Awesome-Lint). This includes a format linting process, so if there are any issues with the build, please address them.

Do you have further questions? Check the contribution guidelines or open an issue.

When you're ready, check off the above acknowledgements and continue with your Pull Request... and thanks!

@tvermaashutosh
Copy link
Contributor Author

@edm00se
Kindly tell me how to resolve this issue. I don't know what the problem is from my side. Could you please resolve this and merge it.

@edm00se
Copy link
Owner

edm00se commented Oct 14, 2023

The linter is complaining about a dead url, which does not appear to be accurate. The preview build by vercel failed to run because with the higher volume of people contributing this month, we’ve exceeded my free account’s build limit. I believe that should be cleared within 24 hours. As for the lint action, a re-run didn’t fix it, so I’ll have a look later this evening. Thanks.

@tvermaashutosh
Copy link
Contributor Author

@edm00se
Ok Eric, I understand.
Thanks for your reply. Look into it and see if it fixes the issue.

@tvermaashutosh
Copy link
Contributor Author

@edm00se
Is it fixed from your end?

@edm00se
Copy link
Owner

edm00se commented Oct 17, 2023

I'm looking into the linter, which is giving us the false positive on the dead url check.

@tvermaashutosh I suspect the lint checking rule is having an issue with the link containing the accented character. This shouldn't be the case, utf8 encoding takes care of most of this silliness, but here we are. There appears to be an open issue from the source of the rule.

remarkjs/remark-lint-no-dead-urls#41

Copy link
Owner

@edm00se edm00se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, to get around this, please update the game link to use the Board Game Geek link and see if that fixes it; I believe this to be the same game. If the image url has the same issue, it would need to be changed as well.

@tvermaashutosh
Copy link
Contributor Author

tvermaashutosh commented Oct 17, 2023

Ok @edm00se lemme do these changes and make new commits.

@tvermaashutosh
Copy link
Contributor Author

@edm00se
Thank you for your valuable assistance.
All my checks have passed when I updated the link.
I request you to kindly review my PR and merge it.

Copy link
Owner

@edm00se edm00se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things are looking good! Thank you for contributing.

refs #269

@edm00se edm00se merged commit de29eb0 into edm00se:main Oct 17, 2023
1 check passed
@edm00se edm00se added the hacktoberfest-accepted thanks for participating! label Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted thanks for participating!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants