Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Outfoxed board game #391

Merged
merged 8 commits into from
Oct 17, 2023
Merged

Added Outfoxed board game #391

merged 8 commits into from
Oct 17, 2023

Conversation

Asymtode712
Copy link
Contributor

@Asymtode712 Asymtode712 commented Oct 17, 2023

Submitting this PR means you have:

  • searched the readme file and searched the open pull requests (no duplicates please)
  • and will follow the desired format
  • used image links that resolve correctly, are appropriately sized, and are served over HTTPS

Once your PR is created, it will trigger a build a GitHub Action (Awesome-Lint). This includes a format linting process, so if there are any issues with the build, please address them.

Do you have further questions? Check the contribution guidelines or open an issue.

When you're ready, check off the above acknowledgements and continue with your Pull Request... and thanks!

@Asymtode712
Copy link
Contributor Author

@edm00se Please review my PR and merge it if everything's right

Copy link
Owner

@edm00se edm00se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking the linter action's output shows that it's failing, while the message seems slightly off, I believe it's not happy with the title. Additionally, the image source will not work, please use one from wikipedia or BGG.

readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
Co-authored-by: Eric McCormick <edm00se@users.noreply.github.com>
@Asymtode712
Copy link
Contributor Author

@edm00se I have done the changes as suggested by you. Please review my request

readme.md Outdated Show resolved Hide resolved
Copy link
Owner

@edm00se edm00se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing!

refs #269

@edm00se edm00se merged commit 15488c7 into edm00se:main Oct 17, 2023
1 check passed
@edm00se edm00se added the hacktoberfest-accepted thanks for participating! label Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted thanks for participating!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants