Merge pull request #3 from edmarfelipe/feat/code_coverage

chore: Add test for hello handler with language set to pt

.github/workflows/build.yml

@@ -65,6 +65,8 @@ jobs:
     runs-on: ubuntu-latest
     needs: test
     permissions:
-      actions: read # to download
+      contents: read
+      actions: read # to download code coverage results from "test" job
+      pull-requests: write # write permission needed to comment on PR
     steps:
       - uses: fgrosse/go-coverage-report@v1.0.2

internal/httpserver/handler_hello.go

@@ -21,7 +21,7 @@ func HelloHandler(w http.ResponseWriter, r *http.Request) {
 	}
 
 	if _, ok := msgs[lang]; !ok {
-		WriteJSON(w, http.StatusBadRequest, ErrorResponse{Error: "invalid language"})
+		WriteBadRequest(w, "invalid language")
 		return
 	}
 

internal/httpserver/handler_hello_test.go

@@ -30,4 +30,42 @@ func TestHelloHandler(t *testing.T) {
 			t.Fatalf("expected message %s, got %s", "Hello", hello.Message)
 		}
 	})
+
+	t.Run("Should return a hello response with language set to pt", func(t *testing.T) {
+		resp, err := http.Get(srv.URL + "?lang=pt")
+		if err != nil {
+			t.Fatalf("expected no error, got %v", err)
+		}
+
+		if resp.StatusCode != http.StatusOK {
+			t.Fatalf("expected status code %d, got %d", http.StatusOK, resp.StatusCode)
+		}
+		defer resp.Body.Close()
+
+		var hello httpserver.HelloResponse
+		json.NewDecoder(resp.Body).Decode(&hello)
+
+		if hello.Message != "Olá" {
+			t.Fatalf("expected message %s, got %s", "Olá", hello.Message)
+		}
+	})
+
+	t.Run("Should return error response with invalid language", func(t *testing.T) {
+		resp, err := http.Get(srv.URL + "?lang=invalid")
+		if err != nil {
+			t.Fatalf("expected no error, got %v", err)
+		}
+
+		if resp.StatusCode != http.StatusBadRequest {
+			t.Fatalf("expected status code %d, got %d", http.StatusBadRequest, resp.StatusCode)
+		}
+		defer resp.Body.Close()
+
+		var errResp httpserver.ErrorResponse
+		json.NewDecoder(resp.Body).Decode(&errResp)
+
+		if errResp.Error != "invalid language" {
+			t.Fatalf("expected error message %s, got %s", "invalid language", errResp.Error)
+		}
+	})
 }