Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type annotations and type checking #1

Open
edwinbalani opened this issue Nov 20, 2020 · 1 comment
Open

Add type annotations and type checking #1

edwinbalani opened this issue Nov 20, 2020 · 1 comment
Assignees
@edwinbalani
Labels
enhancement New feature or request

Comments

@edwinbalani
Copy link
Owner

Currently the source is devoid of type annotations. Especially for something security-related, it would be a good idea to add this, to both to ensure type correctness and to annotate the public API of the library to ensure callers are using it properly.
@edwinbalani edwinbalani added the enhancement New feature or request label Nov 20, 2020
@edwinbalani edwinbalani mentioned this issue Nov 20, 2020
Open
@edwinbalani edwinbalani self-assigned this Dec 3, 2020
@edwinbalani edwinbalani changed the title Add type annotations Add type annotations and type checking Dec 3, 2020
@edwinbalani
Copy link
Owner Author

If we're adding type annotations, we should simultaneously throw in mypy for type checking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edwinbalani edwinbalani

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@edwinbalani