Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BD-46] refactor: refactoring buttons variants #75

Closed

Conversation

PKulkoRaccoonGang
Copy link
Contributor

@PKulkoRaccoonGang PKulkoRaccoonGang commented Jul 27, 2023

Description

  • refactored Button variants
  • refactored overrides.scss file

Issue: openedx/paragon#2389

@openedx-webhooks
Copy link

openedx-webhooks commented Jul 27, 2023

Thanks for the pull request, @PKulkoRaccoonGang!

When this pull request is ready, tag your edX technical lead.

Thanks for your pull request, but this repo does not accept outside contributions unless they are under contract. If you think this is an error, please contact @nedbat.

@adamstankiewicz
Copy link
Member

[inform] Note: the failing openedx/cla check is OK. This work is under contract with Raccoon Gang (BD-46).

@@ -2,7 +2,7 @@
"elevation": {
"image": {
"thumbnail": {
"box-shadow": { "value": "none" }
"box-shadow": { "value": "0 1px 2px rgba(0, 0, 0, .075)" }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[clarification] Looking at the Image component using the edX.org theme on the Paragon docs site for master, it looks like the Image thumbnail doesn't have a box-shadow?

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes you are right
This pull request will be closed, and a new one with corrections will be opened here

adamstankiewicz and others added 18 commits December 27, 2023 11:05
… (edx#59)

Co-authored-by: Peter Kulko <93188219+PKulkoRaccoonGang@users.noreply.github.com>
* fix: upgrade paragon
* fix: delete dist folder
* fix: add empty .npmignore to ensure dist folder gets published

* chore: ci workflow

* chore: rename ci job

* chore: rename ci job

* chore: build design tokens
* feat: compile source tokens only
* fix: upgrade to paragon-alpha.34
* Revert "fix: include token for color-primary-300 for dark theme (edx#73)"

This reverts commit 977f62a.

* Revert "feat: POC for dark mode demo (edx#71)"

This reverts commit b76772c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants