Skip to content

Commit

Permalink
test: Add Node 20 to CI matrix (#26)
Browse files Browse the repository at this point in the history
* test: Add Node 20 to CI matrix

* refactor: updated node version for testing-js
  • Loading branch information
BilalQamar95 authored Oct 4, 2024
1 parent 9b21338 commit 4857ae0
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
6 changes: 3 additions & 3 deletions .github/scripts/testing-js.sh
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
if [[ $NODE == 18 ]]
if [[ $NODE == 20 ]]
then
export NODE_VERSION=18.20.2
export NODE_VERSION=20.15.1
else
export NODE_VERSION=16.14.0
export NODE_VERSION=18.20.2
fi

docker exec -t insights_testing bash -c "
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@ jobs:
python-version: ["3.8", "3.12"]
os: [ubuntu-20.04]
toxenv: [django42]
node: [18]
node: [18, 20]
continue-on-error: ${{ matrix.node == 20 }}
env:
DATA_API_VERSION: "latest"
steps:
Expand Down

0 comments on commit 4857ae0

Please sign in to comment.