Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add upgrade banner in the FC47 Primary Course card view #9

Merged
merged 1 commit into from
Jul 22, 2024
Merged

fix: Add upgrade banner in the FC47 Primary Course card view #9

merged 1 commit into from
Jul 22, 2024

Conversation

k1rill
Copy link
Collaborator

@k1rill k1rill commented Jul 17, 2024 •
edited
Loading

Relates to openedx#340

Screenshot_20240717_200224 Screenshot_20240717_200302

@k1rill k1rill requested a review from HamzaIsrar12 July 17, 2024 09:32
@k1rill k1rill force-pushed the 2U/fix/update_banner_gallery branch 3 times, most recently from 3b3cca2 to ef54d1b Compare July 17, 2024 17:02
@k1rill k1rill linked an issue Jul 17, 2024 that may be closed by this pull request
[Android] Add upgrade banner in the FC47 Primary Course card view openedx/openedx-app-android#340
Open
HamzaIsrar12
HamzaIsrar12 requested changes Jul 18, 2024
View reviewed changes
Copy link

@HamzaIsrar12 HamzaIsrar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes. Minor nits and suggestions only. 🏎️

dashboard/src/test/java/org/openedx/dashboard/presentation/DashboardViewModelTest.kt Show resolved Hide resolved
dashboard/src/main/java/org/openedx/courses/presentation/DashboardGalleryViewModel.kt Outdated Show resolved Hide resolved
dashboard/src/main/java/org/openedx/dashboard/presentation/DashboardListViewModel.kt Outdated Show resolved Hide resolved
core/src/main/java/org/openedx/core/domain/interactor/IAPInteractor.kt Outdated Show resolved Hide resolved
dashboard/src/main/java/org/openedx/dashboard/presentation/DashboardListViewModel.kt Outdated Show resolved Hide resolved
dashboard/src/main/java/org/openedx/courses/presentation/DashboardGalleryViewModel.kt Outdated Show resolved Hide resolved
dashboard/src/main/java/org/openedx/courses/presentation/DashboardGalleryViewModel.kt Outdated Show resolved Hide resolved
dashboard/src/main/java/org/openedx/courses/presentation/DashboardGalleryViewModel.kt Show resolved Hide resolved
core/src/main/java/org/openedx/core/domain/interactor/IAPInteractor.kt Outdated Show resolved Hide resolved
@k1rill k1rill force-pushed the 2U/fix/update_banner_gallery branch from ef54d1b to 0522fe0 Compare July 18, 2024 07:58
@k1rill k1rill requested a review from HamzaIsrar12 July 18, 2024 07:58
@k1rill
Copy link
Collaborator Author

k1rill commented Jul 18, 2024

@HamzaIsrar12 ready for another pass

HamzaIsrar12
HamzaIsrar12 requested changes Jul 18, 2024
View reviewed changes
Copy link

@HamzaIsrar12 HamzaIsrar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should apply the new code to the SettingsViewModel as well. Most of the components are the same; we just need to add a couple of parameters here and there.

@k1rill k1rill force-pushed the 2U/fix/update_banner_gallery branch 2 times, most recently from 829e99f to 2b555cd Compare July 22, 2024 15:08
@k1rill k1rill force-pushed the 2U/fix/update_banner_gallery branch from 2b555cd to 73f72f0 Compare July 22, 2024 15:21
@k1rill k1rill requested a review from HamzaIsrar12 July 22, 2024 15:29
@HamzaIsrar12 HamzaIsrar12 merged commit 513d2f0 into edx:2U/develop Jul 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HamzaIsrar12 HamzaIsrar12 HamzaIsrar12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Android] Add upgrade banner in the FC47 Primary Course card view
2 participants
@k1rill @HamzaIsrar12