feat: persist cta dismissal and change survey trigger #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alangsto
commented
Oct 19, 2023
| @@ -94,7 +95,7 @@ const ToggleXpert = ({ | |||
| ${contentToolsEnabled ? 'chat-content-tools-margin' : ''}` | |||
| } | |||
| > | |||
| {!hasDismissed && ( | |||
| {(!localStorage.getItem('dismissedLearningAssistantCallToAction') && !hasDismissed) && ( | |||
There was a problem hiding this comment.
We need both local storage and state change in order to re-render the page when the call to action is dismissed (as state change will trigger a re-render)
alangsto
force-pushed
the
alangsto/update_ui
branch
from
30bc19e
to
a0a1738
Compare
Codecov Report
@@ Coverage Diff @@
## main #33 +/- ##
==========================================
+ Coverage 87.06% 87.12% +0.06%
==========================================
Files 13 13
Lines 201 202 +1
Branches 26 26
==========================================
+ Hits 175 176 +1
Misses 26 26
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
alangsto
force-pushed
the
alangsto/update_ui
branch
from
a0a1738
to
a1b6291
Compare
Zacharis278
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MST-2156
If a user dismisses the CTA, that dismissal should be persisted. Additionally, we would only like to trigger the survey after a user has interacted with the learning assistant, so the hotjar event should only be triggered after a user sends and receives a message.