feat: update to popup #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alangsto
force-pushed
the
alangsto/update_product_tour
branch
from
b77e0d6
to
bc8408d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #39 +/- ##
==========================================
+ Coverage 79.89% 82.35% +2.45%
==========================================
Files 13 13
Lines 199 204 +5
Branches 24 27 +3
==========================================
+ Hits 159 168 +9
+ Misses 38 34 -4
Partials 2 2 ☔ View full report in Codecov by Sentry. |
Zacharis278
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COSMO-111
The product tour is meant to have multiple checkpoints, and because it doesn't, there is no option to dismiss the component. Because we only have a singular popup, we should use the ModalPopup component instead.
This PR ensures that the popup message is dismissible, and also only displays one CTA at a time as to avoid visual clutter. Here is what the new experience looks like: