Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update toggle button width #45

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Conversation

alangsto
Copy link
Member

COSMO-203

The Xpert toggle button was appearing with a larger width than intended in safari. No width was specified (either by percentage or pixel), so browsers likely calculated/inferred the width for the toggle element differently.

This change specifies a pixel width, so that the button appears the same across browsers.

Before:
Screenshot 2024-03-18 at 10 53 10 AM

After:
Screenshot 2024-03-18 at 10 53 23 AM

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.36%. Comparing base (d42982c) to head (3e0f107).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #45   +/-   ##
=======================================
  Coverage   81.36%   81.36%           
=======================================
  Files          13       13           
  Lines         220      220           
  Branches       30       30           
=======================================
  Hits          179      179           
  Misses         39       39           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alangsto alangsto merged commit 7ed6b59 into main Mar 18, 2024
6 checks passed
@alangsto alangsto deleted the alangsto/update_toggle_css branch March 18, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants