-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update call to action message #20
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. It looks like are some linting failures.
Can you let me know when you've rebased on top of my recent changes, and I can take another look?
36a7bb0
to
bedcb0a
Compare
Codecov Report
@@ Coverage Diff @@
## main #20 +/- ##
==========================================
+ Coverage 85.81% 86.45% +0.64%
==========================================
Files 11 11
Lines 148 155 +7
Branches 15 17 +2
==========================================
+ Hits 127 134 +7
Misses 21 21
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bedcb0a
to
2a648d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
className="dismiss-button mx-2 mt-2 bg-gray" | ||
size="sm" | ||
/> | ||
<div className="action-message open-negative-margin px-3 py-3 my-2"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: You can combine px-3 py-3
into just p-3
.
Update call to action button and add ability to dismiss message.
With call to action:
With call to action dismissed: