Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update call to action message #20

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Conversation

alangsto
Copy link
Member

@alangsto alangsto commented Aug 29, 2023

Update call to action button and add ability to dismiss message.

With call to action:
Screenshot 2023-08-29 at 1 48 28 PM

With call to action dismissed:
Screenshot 2023-08-29 at 1 48 38 PM

@alangsto alangsto marked this pull request as ready for review August 29, 2023 16:23
Copy link
Member

@MichaelRoytman MichaelRoytman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. It looks like are some linting failures.

Can you let me know when you've rebased on top of my recent changes, and I can take another look?

@alangsto alangsto force-pushed the alangsto/update_message branch 4 times, most recently from 36a7bb0 to bedcb0a Compare August 29, 2023 17:53
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #20 (bedcb0a) into main (49d8db1) will increase coverage by 0.64%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
+ Coverage   85.81%   86.45%   +0.64%     
==========================================
  Files          11       11              
  Lines         148      155       +7     
  Branches       15       17       +2     
==========================================
+ Hits          127      134       +7     
  Misses         21       21              
Files Changed Coverage Δ
src/components/ToggleXpertButton/index.jsx 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@MichaelRoytman MichaelRoytman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

className="dismiss-button mx-2 mt-2 bg-gray"
size="sm"
/>
<div className="action-message open-negative-margin px-3 py-3 my-2">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: You can combine px-3 py-3 into just p-3.

@alangsto alangsto merged commit 4e4d88c into main Aug 29, 2023
4 checks passed
@alangsto alangsto deleted the alangsto/update_message branch August 29, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants