feat: change paragon to use @openedx/paragon #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leangseu-edx
force-pushed
the
lk/update-paragon
branch
from
a1582eb
to
3c55da3
Compare
BREAKING CHANGE: - replace @edx/paragon in favor of @openedx/paragon because @edx/paragon is moved https://www.npmjs.com/package/@edx/paragon - remove react-intl. It should use intl from @edx/frontend-platform
leangseu-edx
force-pushed
the
lk/update-paragon
branch
from
3c55da3
to
1f4b34d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #47 +/- ##
=======================================
Coverage 81.36% 81.36%
=======================================
Files 13 13
Lines 220 220
Branches 30 30
=======================================
Hits 179 179
Misses 39 39
Partials 2 2 ☔ View full report in Codecov by Sentry. |
ilee2u
approved these changes
Mar 26, 2024
|
[question], why this work is redone when we already had an open PR for the same work. we have notified the squad about these changes as well cc: @jristau1984 |
|
@abdullahwaheed sorry, I wasn't aware of that pr. I was just focusing on getting other feature unblocked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
@edx/paragonis getting moved to@openedx/paragon@edx/frontend-buildis getting moved to@openedx/frontend-build@edx/frontend-platform@7andreact-intl@6BREAKING CHANGE:
@edx/paragonwith@openedx/paragon@edx/frontend-platformto version 7@edx/frontend-buildwith@openedx/frontend-build