Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Xpert styling issues, fix lingering bugs, and make improvements. #8

Merged
merged 3 commits into from
Aug 21, 2023
Merged

Fix Xpert styling issues, fix lingering bugs, and make improvements. #8

merged 3 commits into from
Aug 21, 2023

Commits on Aug 21, 2023

  1. fix: Xpert styling 

    This commit includes a number of CSS fixes and changes. The fundamental issue is that the existing Xpert code used Tailwind classes, which we do not have access to in the learning MFE. Furthermore, the existing Xpert code did not make use of Bootstrap.

This commit replaces Tailwind classes with Bootstrap classes, where equivalent Bootstrap classes exist. Tailwind classes that did not have an equivalent Bootstrap class are replaced by equivalent CSS. The CSS files were converted to SCSS files.

Other changes include conditionally rendering the Sidebar component instead of relying on opacity and absolute positioning to hide and show the Sidebar, remove unncessary styling, and relying on flexbox for positioning where possible over absolute positioning.
    @MichaelRoytman
    MichaelRoytman committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    0c26e98 View commit details
    Browse the repository at this point in the history

  2. fix: Xpert bugs 

    This commit fixes a number of bugs in the Xpert. These fixes include changing the propType for the chatboxContainerRef from a string to an object, storing serializable values for dates in Redux, and correctly dispatching the addChatMessage thunk action creator.
    @MichaelRoytman
    MichaelRoytman committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    57987df View commit details
    Browse the repository at this point in the history

  3. refactor: Xpert improvements 

    This commit makes a number of improvements to the Xpert code. These improvements include moving the API call logic from Xpert widget to Sidebar component to make it easier to follow how an API call is made and to avoid side effects, moving the API loading state to the Redux store to have a cleaner data flow and to make the data available to the entire component tree, and correctly scrolling to the bottom of the ChatBox when the Sidebar is opened.
    @MichaelRoytman
    MichaelRoytman committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    c219134 View commit details
    Browse the repository at this point in the history