feat: replace waffle flag with setting #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alangsto
force-pushed
the
alangsto/update_waffle_flag_to_django_setting
branch
3 times, most recently
from
6bb55f5
to
267f981
Compare
alangsto
force-pushed
the
alangsto/update_waffle_flag_to_django_setting
branch
3 times, most recently
from
de6e22b
to
58fd79d
Compare
MichaelRoytman
approved these changes
Feb 14, 2024
tests/test_api.py
Outdated
| @@ -223,7 +224,8 @@ def setUp(self): | |||
| (False, False, False, False), | |||
| ) | |||
| @ddt.unpack | |||
| @patch('learning_assistant.api.learning_assistant_available') | |||
| @patch('learning_assistant.api.learning_assistant_available_flag') | |||
| @override_settings(LEARNING_ASSISTANT_AVAILABLE=False) | |||
There was a problem hiding this comment.
Do these tests fail if LEARNING_ASSISTANT_AVAILABLE=True? Or are you just trying to ensure that these tests are testing the waffle flag logic and not the Django setting?
There was a problem hiding this comment.
I was trying to limit the scope of this test, and not introduce more booleans to test the logic of the django setting. Although now I'm realizing because I added a test for the api function learning_assistant_available, I could mock that here, and avoid overriding the setting.
alangsto
force-pushed
the
alangsto/update_waffle_flag_to_django_setting
branch
from
491ee95
to
d7dd451
Compare
alangsto
force-pushed
the
alangsto/update_waffle_flag_to_django_setting
branch
from
d7dd451
to
2db2806
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COSMO-191
To prepare for a wider release, the use of a course waffle flag to enable the learning assistant should be replaced by a platform wide django setting.
If no setting is defined, the feature will default to a disabled state.