Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Powershell version of "fake remote" for rebase exercises #232

Open
JKrag opened this issue Mar 30, 2020 · 3 comments
Open

Powershell version of "fake remote" for rebase exercises #232

JKrag opened this issue Mar 30, 2020 · 3 comments
Labels
enhancement Good First Issue Easy to solve for newcomers., please grab :) Hacktoberfest Powershell

Comments

@JKrag
Copy link
Contributor

JKrag commented Mar 30, 2020

In #192 I made some general features to support "real" remotes in katas and used these in the "reorder history" kata.
I never completed the Powershell version, although I might have an unfinished version on a branch somewhere. I am not PS proficient, so I would love if someone else could make these.

I will make separate issues for implementing these changes on other katas

@JKrag JKrag added enhancement Good First Issue Easy to solve for newcomers., please grab :) Powershell labels Mar 30, 2020
@JKrag
Copy link
Contributor Author

JKrag commented Mar 30, 2020

I now found my lost branch with WIP powershell version. I don't remember exactly what state it was in, but it was not complete enough to include in #192
I have pushed the branch to improve-rebase-powershell as a starting point.

@bothzoli
Copy link
Contributor

bothzoli commented Jun 9, 2020

hi @JKrag i tested your branch and for me it works correctly.
do you have any issue in particular? i'd be happy to help

@JKrag
Copy link
Contributor Author

JKrag commented Jun 10, 2020

@bothzoli There might actually not be anything missing. I can no longer remember as I did the original work about a year ago. It is quite probable that I made the equivalent changes to the PS version, but without any environment to test it (and no real experience with PS), so I just didn't feel comfortable including it in the original PR. So I might have been lucky and made a bug-free version in the first attempt. Later, I just found my branch laying around, at a time where I didn't have time to investigate, and just pushed it for someone else to look at.
If you have tested it, and both the general utils and the specific changes in the "reorder the history" kata work as intended, then we are probably happy to merge it.
Any comments on this @RandomSort ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Good First Issue Easy to solve for newcomers., please grab :) Hacktoberfest Powershell
Projects
None yet
Development

No branches or pull requests

3 participants