-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: impl MultiInstanceProto #145
Conversation
f5031a6
to
d1893fc
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #145 +/- ##
==========================================
+ Coverage 93.77% 93.79% +0.01%
==========================================
Files 227 228 +1
Lines 4739 4815 +76
Branches 509 526 +17
==========================================
+ Hits 4444 4516 +72
- Misses 295 299 +4
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
@Inject({ | ||
name: 'dynamicLogger', | ||
}) | ||
@LogPath('bar') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不加 Qualifier 默认返回的是第一个?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
必须加。不加会挂的。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
没有 default 这个概念。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好吧,那我将 oss 的写法改一下,默认就是多实例的。
d1893fc
to
6fdfeef
Compare
Checklist
npm test
passesAffected core subsystem(s)
Description of change