Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: impl MultiInstanceProto #145

Merged
merged 1 commit into from
Aug 24, 2023
Merged

feat: impl MultiInstanceProto #145

merged 1 commit into from
Aug 24, 2023

Conversation

killagu
Copy link
Contributor

@killagu killagu commented Aug 24, 2023

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@fengmk2 fengmk2 added the enhancement New feature or request label Aug 24, 2023
@killagu killagu changed the title WIP: feat: impl MultiInstanceProto feat: impl MultiInstanceProto Aug 24, 2023
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Patch coverage: 89.11% and project coverage change: +0.01% 🎉

Comparison is base (fa454c1) 93.77% compared to head (6fdfeef) 93.79%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #145      +/-   ##
==========================================
+ Coverage   93.77%   93.79%   +0.01%     
==========================================
  Files         227      228       +1     
  Lines        4739     4815      +76     
  Branches      509      526      +17     
==========================================
+ Hits         4444     4516      +72     
- Misses        295      299       +4     
Files Changed Coverage Δ
core/lifecycle/src/LifycycleUtil.ts 96.36% <ø> (ø)
core/metadata/src/model/EggPrototype.ts 100.00% <ø> (ø)
plugin/orm/lib/SingletonModelProto.ts 68.96% <0.00%> (-5.11%) ⬇️
plugin/tegg/lib/EggModuleLoader.ts 100.00% <ø> (ø)
standalone/standalone/src/EggModuleLoader.ts 100.00% <ø> (ø)
...alone/standalone/src/StandaloneInnerObjectProto.ts 67.74% <0.00%> (-2.26%) ⬇️
core/runtime/src/impl/ModuleLoadUnitInstance.ts 82.25% <28.57%> (-2.75%) ⬇️
plugin/tegg/lib/EggCompatibleProtoImpl.ts 93.93% <50.00%> (-6.07%) ⬇️
...ic-inject-runtime/src/EggObjectFactoryPrototype.ts 78.78% <77.77%> (-5.09%) ⬇️
...metadata/src/factory/EggPrototypeCreatorFactory.ts 93.10% <90.90%> (+2.62%) ⬆️
... and 14 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@fengmk2 fengmk2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@Inject({
name: 'dynamicLogger',
})
@LogPath('bar')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不加 Qualifier 默认返回的是第一个?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

必须加。不加会挂的。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

没有 default 这个概念。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好吧,那我将 oss 的写法改一下,默认就是多实例的。

@killagu killagu added this pull request to the merge queue Aug 24, 2023
Merged via the queue into master with commit 12fd5cf Aug 24, 2023
16 of 17 checks passed
@killagu killagu deleted the feat/multi_instance branch August 24, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants