-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix use MultiInstanceProto from other modules #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
目前只看懂的单测,允许跨 module Inject 了。 |
killagu
force-pushed
the
fix/multi_instance
branch
from
August 29, 2023 05:38
6c12dc4
to
ce31f74
Compare
killagu
force-pushed
the
fix/multi_instance
branch
from
August 29, 2023 05:40
ce31f74
to
fa92d9b
Compare
killagu
changed the title
WIP: fix: fix use MultiInstanceProto from other modules
fix: fix use MultiInstanceProto from other modules
Aug 29, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #147 +/- ##
==========================================
- Coverage 93.81% 92.49% -1.33%
==========================================
Files 229 230 +1
Lines 4851 4875 +24
Branches 532 538 +6
==========================================
- Hits 4551 4509 -42
- Misses 300 366 +66
☔ View full report in Codecov by Sentry. |
fengmk2
approved these changes
Aug 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
代码复杂度越来越低了!+1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm test
passesAffected core subsystem(s)
Description of change