Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix use MultiInstanceProto from other modules #147

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

killagu
Copy link
Contributor

@killagu killagu commented Aug 27, 2023

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@fengmk2
Copy link
Member

fengmk2 commented Aug 27, 2023

目前只看懂的单测,允许跨 module Inject 了。

@fengmk2 fengmk2 added the bug Something isn't working label Aug 27, 2023
@killagu killagu changed the title WIP: fix: fix use MultiInstanceProto from other modules fix: fix use MultiInstanceProto from other modules Aug 29, 2023
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Patch coverage: 96.03% and project coverage change: -1.33% ⚠️

Comparison is base (5bf0b2a) 93.81% compared to head (fa92d9b) 92.49%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #147      +/-   ##
==========================================
- Coverage   93.81%   92.49%   -1.33%     
==========================================
  Files         229      230       +1     
  Lines        4851     4875      +24     
  Branches      532      538       +6     
==========================================
- Hits         4551     4509      -42     
- Misses        300      366      +66     
Files Changed Coverage Δ
core/metadata/src/model/AppGraph.ts 95.09% <95.09%> (ø)
core/core-decorator/src/util/PrototypeUtil.ts 100.00% <100.00%> (ø)
core/metadata/index.ts 100.00% <100.00%> (ø)
...etadata/src/impl/LoadUnitMultiInstanceProtoHook.ts 100.00% <100.00%> (ø)
plugin/tegg/lib/EggModuleLoader.ts 100.00% <100.00%> (ø)
standalone/standalone/src/EggModuleLoader.ts 100.00% <100.00%> (ø)
standalone/standalone/src/Runner.ts 93.39% <100.00%> (+0.25%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@fengmk2 fengmk2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

代码复杂度越来越低了!+1

@killagu killagu added this pull request to the merge queue Aug 29, 2023
Merged via the queue into master with commit b71af60 Aug 29, 2023
16 of 17 checks passed
@killagu killagu deleted the fix/multi_instance branch August 29, 2023 06:35
@killagu
Copy link
Contributor Author

killagu commented Aug 29, 2023

  • @eggjs/aop-decorator@3.18.1
  • @eggjs/controller-decorator@3.18.1
  • @eggjs/core-decorator@3.18.1
  • @eggjs/egg-module-common@3.18.1
  • @eggjs/eventbus-decorator@3.18.1
  • @eggjs/standalone-decorator@3.18.1
  • @eggjs/tegg@3.18.1
  • @eggjs/tegg-aop-plugin@3.18.1
  • @eggjs/tegg-aop-runtime@3.18.1
  • @eggjs/tegg-background-task@3.18.1
  • @eggjs/tegg-common-util@3.18.1
  • @eggjs/tegg-config@3.18.1
  • @eggjs/tegg-controller-plugin@3.18.1
  • @eggjs/tegg-dynamic-inject@3.18.1
  • @eggjs/tegg-dynamic-inject-runtime@3.18.1
  • @eggjs/tegg-eventbus-plugin@3.18.1
  • @eggjs/tegg-eventbus-runtime@3.18.1
  • @eggjs/tegg-lifecycle@3.18.1
  • @eggjs/tegg-loader@3.18.1
  • @eggjs/tegg-metadata@3.18.1
  • @eggjs/tegg-orm-decorator@3.18.1
  • @eggjs/tegg-orm-plugin@3.18.1
  • @eggjs/tegg-plugin@3.18.1
  • @eggjs/tegg-runtime@3.18.1
  • @eggjs/tegg-schedule-decorator@3.18.1
  • @eggjs/tegg-schedule-plugin@3.18.1
  • @eggjs/tegg-standalone@3.18.1
  • @eggjs/tegg-transaction-decorator@3.18.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants