Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tegg plugin support ModuleConfig #162

Merged
merged 3 commits into from
Nov 2, 2023
Merged

Conversation

killagu
Copy link
Contributor

@killagu killagu commented Nov 2, 2023

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1a24e48) 92.44% compared to head (ad8d04a) 92.53%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #162      +/-   ##
==========================================
+ Coverage   92.44%   92.53%   +0.08%     
==========================================
  Files         233      235       +2     
  Lines        4940     4999      +59     
  Branches      554      531      -23     
==========================================
+ Hits         4567     4626      +59     
  Misses        373      373              
Files Coverage Δ
core/common-util/index.ts 100.00% <100.00%> (ø)
core/common-util/src/ModuleConfigs.ts 100.00% <ø> (ø)
core/core-decorator/index.ts 100.00% <100.00%> (ø)
core/core-decorator/src/decorator/ConfigSource.ts 100.00% <100.00%> (ø)
core/tegg/index.ts 100.00% <100.00%> (ø)
plugin/tegg/app.ts 100.00% <100.00%> (ø)
plugin/tegg/lib/ConfigSourceLoadUnitHook.ts 100.00% <100.00%> (ø)
plugin/tegg/lib/EggAppLoader.ts 98.43% <100.00%> (+0.07%) ⬆️
plugin/tegg/lib/ModuleConfigLoader.ts 100.00% <100.00%> (ø)
...ndalone/standalone/src/ConfigSourceLoadUnitHook.ts 100.00% <ø> (ø)
... and 1 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@fengmk2 fengmk2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@fengmk2 fengmk2 added this pull request to the merge queue Nov 2, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Nov 2, 2023
@fengmk2 fengmk2 merged commit 58bd9fa into master Nov 2, 2023
17 checks passed
@fengmk2 fengmk2 deleted the feat/module_configs branch November 2, 2023 15:02
@killagu
Copy link
Contributor Author

killagu commented Nov 3, 2023

  • @eggjs/aop-decorator@3.25.0
  • @eggjs/controller-decorator@3.25.0
  • @eggjs/core-decorator@3.25.0
  • @eggjs/egg-module-common@3.25.0
  • @eggjs/eventbus-decorator@3.25.0
  • @eggjs/standalone-decorator@3.25.0
  • @eggjs/tegg@3.25.0
  • @eggjs/tegg-aop-plugin@3.25.0
  • @eggjs/tegg-aop-runtime@3.25.0
  • @eggjs/tegg-background-task@3.25.0
  • @eggjs/tegg-common-util@3.25.0
  • @eggjs/tegg-config@3.25.0
  • @eggjs/tegg-controller-plugin@3.25.0
  • @eggjs/tegg-dynamic-inject@3.25.0
  • @eggjs/tegg-dynamic-inject-runtime@3.25.0
  • @eggjs/tegg-eventbus-plugin@3.25.0
  • @eggjs/tegg-eventbus-runtime@3.25.0
  • @eggjs/tegg-lifecycle@3.25.0
  • @eggjs/tegg-loader@3.25.0
  • @eggjs/tegg-metadata@3.25.0
  • @eggjs/tegg-orm-decorator@3.25.0
  • @eggjs/tegg-orm-plugin@3.25.0
  • @eggjs/tegg-plugin@3.25.0
  • @eggjs/tegg-runtime@3.25.0
  • @eggjs/tegg-schedule-decorator@3.25.0
  • @eggjs/tegg-schedule-plugin@3.25.0
  • @eggjs/tegg-standalone@3.25.0
  • @eggjs/tegg-transaction-decorator@3.25.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants