Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ternary operator rules #620

Merged
merged 3 commits into from
May 30, 2024
Merged

Fix ternary operator rules #620

merged 3 commits into from
May 30, 2024

Conversation

yihozhang
Copy link
Collaborator

No description provided.

@yihozhang yihozhang mentioned this pull request May 30, 2024
Open
@yihozhang yihozhang requested a review from oflatt May 30, 2024 22:50
oflatt
oflatt approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@oflatt oflatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Really reveals the need for better testing

@oflatt oflatt merged commit 9c4fdee into main May 30, 2024
4 checks passed
@oflatt oflatt deleted the yihozhang-fix-top branch May 30, 2024 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oflatt oflatt oflatt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yihozhang @oflatt