Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Change Set to store an Expr as the first child #339

Open
oflatt opened this issue Feb 7, 2024 · 0 comments
Open

Proposal: Change Set to store an Expr as the first child #339

oflatt opened this issue Feb 7, 2024 · 0 comments
Labels

Comments

@oflatt
Copy link
Member

oflatt commented Feb 7, 2024

Right now, the representation of Action::Set looks like this: Set(Head, Vec<GenericAtomTerm<Leaf>>, GenericAtomTerm<Leaf>)
While this is good because it disallows variables or literals as the left child to the set, it's bad because it makes it hard to map over set terms.

The map_exprs function is a bit inconsistent right now because it doesn't map over the first argument of Set.

@oflatt oflatt added the refactor label Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant