Skip to content

Commit

Permalink
feat(ci): runs-on: ubuntu-latest -> ubuntu-22.04 (#1687)
Browse files Browse the repository at this point in the history
### Briefly, what does this PR introduce?
This PR updates the target operating system for CI jobs, from
ubuntu-latest to a more explicit ubuntu-22.04. This is in part to avoid
the automatic update of implicit ubuntu-latest that will break
everything (#1686), and in part
because it makes sense to be explicit about the target operating system.

### What kind of change does this PR introduce?
- [ ] Bug fix (issue #__)
- [x] New feature (issue
actions/runner-images#10636)
- [ ] Documentation update
- [ ] Other: __

### Please check if this PR fulfills the following:
- [ ] Tests for the changes have been added
- [ ] Documentation has been added / updated
- [ ] Changes have been communicated to collaborators

### Does this PR introduce breaking changes? What changes might users
need to make to their code?
No.

### Does this PR change default behavior?
No.
  • Loading branch information
wdconinc authored Dec 3, 2024
1 parent 906a443 commit 263d005
Showing 1 changed file with 23 additions and 23 deletions.
46 changes: 23 additions & 23 deletions .github/workflows/linux-eic-shell.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ jobs:
env:
# env cannot be used in matrix, but outputs can
# so this job turns env into outputs
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
outputs:
platform_json: ${{ steps.define.outputs.platform_json }}
release_json: ${{ steps.define.outputs.release_json }}
Expand All @@ -60,7 +60,7 @@ jobs:
echo "release_json=[\"${{ env.release }}\"]" >> $GITHUB_OUTPUT
build:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
needs: env
strategy:
# include multiple compilers for one release version,
Expand Down Expand Up @@ -175,7 +175,7 @@ jobs:
if-no-files-found: error

clang-tidy-iwyu:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
needs: build
steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -252,7 +252,7 @@ jobs:
run: git diff --exit-code

llvm-cov:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
needs: build
permissions:
statuses: write
Expand Down Expand Up @@ -311,7 +311,7 @@ jobs:
path: build/codecov_report/

detector-info:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
outputs:
hash: ${{ steps.detector-info.outputs.hash }}
steps:
Expand All @@ -326,7 +326,7 @@ jobs:
echo "hash=${hash%% *}" | tee $GITHUB_OUTPUT
npsim-gun:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
needs:
- detector-info
strategy:
Expand Down Expand Up @@ -356,7 +356,7 @@ jobs:
if-no-files-found: error

npsim-gun-EcalLumiSpec:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
needs:
- detector-info
strategy:
Expand Down Expand Up @@ -390,7 +390,7 @@ jobs:
if-no-files-found: error

npsim-dis:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
needs:
- detector-info
strategy:
Expand Down Expand Up @@ -426,7 +426,7 @@ jobs:
if-no-files-found: error

npsim-minbias:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
needs:
- detector-info
strategy:
Expand Down Expand Up @@ -462,7 +462,7 @@ jobs:
if-no-files-found: error

eicrecon-two-stage-running:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
needs:
- build
- npsim-gun
Expand Down Expand Up @@ -526,7 +526,7 @@ jobs:
if-no-files-found: error

eicrecon-eicmkplugin:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
needs:
- build
- npsim-gun
Expand Down Expand Up @@ -569,7 +569,7 @@ jobs:
$PWD/install/bin/eicrecon $JANA_OPTIONS -Pplugins=MyCustomPlugin -Ppodio:output_file=rec_${{ matrix.particle }}_1GeV_20GeV_${{ matrix.detector_config }}.edm4eic.root sim_${{ matrix.particle }}_1GeV_20GeV_${{ matrix.detector_config }}.edm4hep.root
eicrecon-test-plugins:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
needs:
- build
- npsim-gun
Expand Down Expand Up @@ -618,7 +618,7 @@ jobs:
if-no-files-found: error

eicrecon-benchmarks-plugins:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
needs:
- build
- npsim-gun
Expand Down Expand Up @@ -671,7 +671,7 @@ jobs:
if-no-files-found: error

eicrecon-gun:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
needs:
- build
- npsim-gun
Expand Down Expand Up @@ -785,7 +785,7 @@ jobs:
if-no-files-found: error

eicrecon-gun-EcalLumiSpec:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
needs:
- build
- npsim-gun-EcalLumiSpec
Expand Down Expand Up @@ -852,7 +852,7 @@ jobs:
if-no-files-found: error

eicrecon-dis:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
needs:
- build
- npsim-dis
Expand Down Expand Up @@ -985,7 +985,7 @@ jobs:
if-no-files-found: error

trigger-container:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
if: ${{ github.event_name != 'merge_group' && github.event_name != 'schedule' && github.actor != 'dependabot[bot]' }}
needs:
- eicrecon-gun
Expand Down Expand Up @@ -1017,7 +1017,7 @@ jobs:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}

build-docs:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
needs:
- eicrecon-gun
- eicrecon-dis
Expand Down Expand Up @@ -1055,7 +1055,7 @@ jobs:
if-no-files-found: error

list-open-prs:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
outputs:
json: ${{ steps.remap.outputs.json }}
steps:
Expand All @@ -1074,7 +1074,7 @@ jobs:
include.*.head_sha: ${{ toJSON(fromJSON(steps.query.outputs.data).*.head.sha) }}

get-docs-from-open-prs:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
needs:
- build-docs
- list-open-prs
Expand Down Expand Up @@ -1125,7 +1125,7 @@ jobs:
if-no-files-found: ignore

get-docs-from-main:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
needs:
- build-docs
steps:
Expand Down Expand Up @@ -1182,7 +1182,7 @@ jobs:
if-no-files-found: error

collect-docs:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
needs:
- get-docs-from-main
- get-docs-from-open-prs
Expand Down Expand Up @@ -1241,7 +1241,7 @@ jobs:
environment:
name: github-pages
url: ${{ steps.deployment.outputs.page_url }}
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
steps:
- name: Deploy to GitHub Pages
id: deployment
Expand Down

0 comments on commit 263d005

Please sign in to comment.