-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: rm unused options in IterativeVertexFinder.cc #1712
Conversation
Capybara summary for PR 1712
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Changes are quite reasonable, so this looks good-to-go once the IWYU patch gets applied.
on 24.04.0-stable |
I guess I should have continue to ignore the iywu suggestions for headers with acts preprocessors... |
Lack of preprocessors |
This reverts commit 6a17e74.
Reverted. Propose to keep as is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this compiles, this should be good.
Briefly, what does this PR introduce?
This PR removes an entirely unused options variable (and type alias) in IterativeVertexFinder.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
No.