Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rm unused options in IterativeVertexFinder.cc #1712

Merged
merged 3 commits into from
Jan 17, 2025

Conversation

wdconinc
Copy link
Contributor

Briefly, what does this PR introduce?

This PR removes an entirely unused options variable (and type alias) in IterativeVertexFinder.

What kind of change does this PR introduce?

  • Bug fix (issue: unused code)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No.

Does this PR change default behavior?

No.

@wdconinc wdconinc requested review from a team and ruse-traveler and removed request for a team January 15, 2025 23:09
@github-actions github-actions bot added the topic: tracking Relates to tracking reconstruction label Jan 15, 2025
ruse-traveler
ruse-traveler previously approved these changes Jan 16, 2025
Copy link
Contributor

@ruse-traveler ruse-traveler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Changes are quite reasonable, so this looks good-to-go once the IWYU patch gets applied.

@veprbl
Copy link
Member

veprbl commented Jan 16, 2025

/home/runner/work/EICrecon/EICrecon/src/algorithms/tracking/IterativeVertexFinder.cc:14:10: fatal error: 'Acts/Vertexing/IVertexFinder.hpp' file not found
#include <Acts/Vertexing/IVertexFinder.hpp>
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

on 24.04.0-stable

@wdconinc
Copy link
Contributor Author

/home/runner/work/EICrecon/EICrecon/src/algorithms/tracking/IterativeVertexFinder.cc:14:10: fatal error: 'Acts/Vertexing/IVertexFinder.hpp' file not found
#include <Acts/Vertexing/IVertexFinder.hpp>
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

on 24.04.0-stable

I guess I should have continue to ignore the iywu suggestions for headers with acts preprocessors...

@veprbl
Copy link
Member

veprbl commented Jan 16, 2025

Lack of preprocessors

This reverts commit 6a17e74.
@wdconinc
Copy link
Contributor Author

I guess I should have continue to ignore the iywu suggestions for headers with acts preprocessors...

Reverted. Propose to keep as is.

Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this compiles, this should be good.

@wdconinc wdconinc added this pull request to the merge queue Jan 17, 2025
Merged via the queue into main with commit 6dce610 Jan 17, 2025
84 of 86 checks passed
@wdconinc wdconinc deleted the rm-unused-options-IterativeVertexFinder branch January 17, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: tracking Relates to tracking reconstruction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants