Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix compilation for Acts versions from v36 up to v38 #1715

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

wdconinc
Copy link
Contributor

@wdconinc wdconinc commented Jan 16, 2025

Briefly, what does this PR introduce?

This adapts our tracking algorithms to any Acts version between v36 and v38.

The commits in this branch are topologically ordered with reference to the commit message title, Acts PR number, and version validity. All commits compile individually, but no event-for-event validation has been performed. See also #1525.

The support for mulitple versions is done by somewhat extensive use of preprocessor directives based on Acts_VERSION_MAJOR and Acts_VERSION_MINOR.

Builds with: (to be completed)

Needs:

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue: Acts versions are released faster than we can keep up with)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No.

Does this PR change default behavior?

No.

@github-actions github-actions bot added the topic: tracking Relates to tracking reconstruction label Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: tracking Relates to tracking reconstruction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant