Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmarks/ecal_gaps: switch to epic_inner_detector configuration #103

Merged
merged 2 commits into from
Nov 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions benchmarks/ecal_gaps/Snakefile
Original file line number Diff line number Diff line change
Expand Up @@ -49,23 +49,20 @@ exec env DETECTOR_CONFIG={wildcards.DETECTOR_CONFIG} \
"""


DETECTOR_CONFIG=os.environ["DETECTOR_CONFIG"]

rule ecal_gaps:
input:
matplotlibrc=".matplotlibrc",
script="benchmarks/ecal_gaps/ecal_gaps.py",
# TODO pass as a file list?
_=expand(
"sim_output/ecal_gaps/{DETECTOR_CONFIG}/{PARTICLE}/{ENERGY}/{PHASE_SPACE}/{PARTICLE}_{ENERGY}_{PHASE_SPACE}.{INDEX:04d}.eicrecon.tree.edm4eic.root",
DETECTOR_CONFIG=DETECTOR_CONFIG,
"sim_output/ecal_gaps/{{DETECTOR_CONFIG}}/{PARTICLE}/{ENERGY}/{PHASE_SPACE}/{PARTICLE}_{ENERGY}_{PHASE_SPACE}.{INDEX:04d}.eicrecon.tree.edm4eic.root",
PARTICLE=["e-"],
ENERGY=["500MeV", "5GeV", "20GeV"],
PHASE_SPACE=["3to50deg", "45to135deg", "130to177deg"],
INDEX=range(1),
),
output:
directory("results/ecal_gaps"),
directory("results/{DETECTOR_CONFIG}/ecal_gaps"),
threads: workflow.cores
shell:
"""
Expand All @@ -85,5 +82,6 @@ WORKER_PID=$!
env \
MATPLOTLIBRC={input.matplotlibrc} \
OUTPUT_DIR={output} \
DETECTOR_CONFIG={wildcards.DETECTOR_CONFIG} \
python {input.script}
"""
6 changes: 3 additions & 3 deletions benchmarks/ecal_gaps/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ sim:ecal_gaps:
script:
- mkdir -p $LOCAL_DATA_PATH/input
- ln -s $LOCAL_DATA_PATH/input input
- snakemake $SNAKEMAKE_FLAGS --cache --cores 10 ecal_gaps --omit-from ecal_gaps
- snakemake $SNAKEMAKE_FLAGS --cache --cores 10 results/epic_inner_detector/ecal_gaps --omit-from ecal_gaps

bench:ecal_gaps:
extends: .det_benchmark
Expand All @@ -15,7 +15,7 @@ bench:ecal_gaps:
- ln -s $LOCAL_DATA_PATH/input input
- export PYTHONUSERBASE=$LOCAL_DATA_PATH/deps
- pip install -r benchmarks/ecal_gaps/requirements.txt
- snakemake $SNAKEMAKE_FLAGS --cores 8 ecal_gaps
- snakemake $SNAKEMAKE_FLAGS --cores 8 results/epic_inner_detector/ecal_gaps

collect_results:ecal_gaps:
extends: .det_benchmark
Expand All @@ -25,5 +25,5 @@ collect_results:ecal_gaps:
script:
- ls -lrht
- mv results{,_save}/ # move results directory out of the way to preserve it
- snakemake $SNAKEMAKE_FLAGS --cores 1 --delete-all-output ecal_gaps
- snakemake $SNAKEMAKE_FLAGS --cores 1 --delete-all-output results/epic_inner_detector/ecal_gaps
- mv results{_save,}/