Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracking_performances: fix a race condition (several instances of a job uses same file) #108

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Nov 28, 2024

@veprbl veprbl merged commit 8bb6a92 into master Nov 29, 2024
3 checks passed
@veprbl veprbl deleted the pr/tracking_fix_race branch November 29, 2024 03:08
@veprbl
Copy link
Member Author

veprbl commented Nov 29, 2024

@Simple-Shyam FYI

@Simple-Shyam
Copy link
Contributor

Hi @veprbl, I would also like to add to the combined png file, e.g. Can I add DCA also to the below rule by passing two expand (one for DCAT and other for DCAz) in the input? if yes how to redefine the command in this case?
montage -mode concatenate {input[0]} {output} || true
montage -mode concatenate {input[1]} {output} || true
montage -mode concatenate {input[2]} {output} || true

or I define a new rule for each? Similar thing, I will also do for rule "tracking_performance" to produce results in directory("results/tracking_performances/{CAMPAIGN}/").

rule tracking_performance_debug_montage:
input:
expand(
[
"{{CAMPAIGN}}/Debug_Plots/{SEEDING}/pi-/mom/{SEEDING}mom_resol_mom{MOMENTUM:.1f}{{ETA_BIN}}.png",
],
MOMENTUM=[0.5, 1.0, 2.0, 5.0, 10.0, 20.0],
SEEDING=["truth", "real"],
),
output:
"{CAMPAIGN}/Debug_Plots/pi-/mom/mom_resol_debug_{ETA_BIN}.png",
shell:
"""
montage -mode concatenate {input} {output} || true
ls {output}
"""

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants