Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tutorial benchmark for backwards ECAL #6

Closed
wants to merge 2 commits into from

Conversation

OJevons
Copy link

@OJevons OJevons commented Jan 9, 2024

Briefly, what does this PR introduce?

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • [ X] Other: Tutorial

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

Does this PR change default behavior?

.gitlab-ci.yml Outdated
@@ -137,6 +137,7 @@ include:
- local: 'benchmarks/timing/config.yml'
- local: 'benchmarks/b0_tracker/config.yml'
- local: 'benchmarks/others/config.yml'
- local: 'benchmarks/backwards_ecal/config.yml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- local: 'benchmarks/backwards_ecal/config.yml
- local: 'benchmarks/backwards_ecal/config.yml'

Missing a '

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, well spotted. I've fixed that now. Cheers!

@veprbl
Copy link
Member

veprbl commented Jan 10, 2024

Congrats on a successful PR! You can check out your code running by following the Details link below.

@veprbl veprbl closed this Jan 10, 2024
@veprbl veprbl deleted the pr/backwards_ecal_OJevons branch January 29, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants