Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: gas service support on the relayer #8

Merged
merged 54 commits into from
Jan 14, 2025
Merged

feat: gas service support on the relayer #8

merged 54 commits into from
Jan 14, 2025

Conversation

roberts-pumpurs
Copy link
Member

@roberts-pumpurs roberts-pumpurs commented Dec 20, 2024 •
edited
Loading

Describe the changes

  • relayer monitors events from the gas service
  • relayer can combine events from the gateway & gas service if they were created in the same tx
    • it will make associations between the "gas paid" & "call contract" events
  • relayer can refund using the gas service

Related Issue(s)
Closes #24

Checklist

  • Tests have been added/updated for the changes.
  • Documentation has been updated for the changes (if applicable).
  • The code follows Rust's style guidelines.

Additional Context
Add any other context about the pull request here.

@roberts-pumpurs
Copy link
Member Author

From the issue description, the things that are not implemented:

  • realtime monitoring of the gas service via websockets
  • sending "refund gas" txs to the GasService
  • checking if the relayer has the authority over the gas service to even be able to send txs

@frenzox frenzox mentioned this pull request Dec 24, 2024
Merged
3 tasks
frenzox and others added 18 commits January 6, 2025 16:06
@frenzox
feat: relayer gas service support (#10)
bc82f53 
* feat: subscribe to gas service logs

Signed-off-by: Guilherme Felipe da Silva <gfsilva.eng@gmail.com>

* feat: handle refund task

Signed-off-by: Guilherme Felipe da Silva <gfsilva.eng@gmail.com>

* chore: make clippy happy

Signed-off-by: Guilherme Felipe da Silva <gfsilva.eng@gmail.com>

* feat: check relayer as authority of gas service

Signed-off-by: Guilherme Felipe da Silva <gfsilva.eng@gmail.com>

---------

Signed-off-by: Guilherme Felipe da Silva <gfsilva.eng@gmail.com>
@roberts-pumpurs
refactor: hard error when gas service is made to use non-native tokens
3da7f11
@roberts-pumpurs
refactor: change how 2 streams get merged
80ca9a7
@roberts-pumpurs
wip docs
f81a56b
@roberts-pumpurs
refactor: reduce code dupl
1af8079
@roberts-pumpurs
wip
d2a1e13
@roberts-pumpurs
feat: simplified signature realitme scanner
5c71115
@roberts-pumpurs
feat: refactor realtime scanner to make it easier to test
64f347e
@roberts-pumpurs
Merge remote-tracking branch 'origin/main' into rob/relayer-gas-servi…
35785f5 
…ce-support
@roberts-pumpurs
feat: can init gateway using test fixtures
71301b5
@roberts-pumpurs
refactor: updated logic that associates gas events with call contract…
f0b788b 
… events
@roberts-pumpurs
test: wip test for sending gmp messages
22ef0a6
@roberts-pumpurs
test: check if signature scanner works
5ad9667
@roberts-pumpurs
test: check fetching in range
aada1b5
@roberts-pumpurs
test: full test for full history fetching
5465f71
@roberts-pumpurs
test: fix issues with range fetcher
9b4434e
@roberts-pumpurs
refactor: batch fetching will fetch gas and gateway contracts sequent…
ef99659 
…ially rather than in parallel
@roberts-pumpurs
wip
c5f1f62
@roberts-pumpurs roberts-pumpurs mentioned this pull request Jan 13, 2025
Closed
frenzox
frenzox previously approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@frenzox frenzox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. there seems to be failing tests though

@roberts-pumpurs roberts-pumpurs force-pushed the rob/relayer-gas-service-support branch from 173985a to d433797 Compare January 13, 2025 17:59
@roberts-pumpurs roberts-pumpurs force-pushed the rob/relayer-gas-service-support branch from d433797 to bfbd3f2 Compare January 13, 2025 18:08
@roberts-pumpurs roberts-pumpurs merged commit 28facf3 into main Jan 14, 2025
6 checks passed
@roberts-pumpurs roberts-pumpurs deleted the rob/relayer-gas-service-support branch January 14, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frenzox frenzox frenzox left review comments

@tilacog tilacog Awaiting requested review from tilacog

@eloylp eloylp Awaiting requested review from eloylp

Assignees

@frenzox frenzox

@roberts-pumpurs roberts-pumpurs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roberts-pumpurs @frenzox