Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validator core assignments #117

Merged
merged 8 commits into from
Nov 19, 2024
Merged

Add validator core assignments #117

merged 8 commits into from
Nov 19, 2024

Conversation

pantrif
Copy link
Contributor

@pantrif pantrif commented Nov 18, 2024

This implements section 11.3. Guarantor Assignments

@pantrif pantrif requested a review from a team November 18, 2024 09:12
bamzedev
bamzedev reviewed Nov 18, 2024
View reviewed changes
Copy link
Contributor

@bamzedev bamzedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add some comments with equations from the GP, would be much easier to navigate. For instance I can't find R(⌊τ'/R⌋ - 1) ≤ t ≤ τ'

@pantrif pantrif force-pushed the feat/core-assignments branch from e5c90d2 to 511582b Compare November 18, 2024 11:29
@pantrif pantrif force-pushed the feat/core-assignments branch from 5ed62fa to 8a2fb36 Compare November 19, 2024 07:46
greywolve
greywolve approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@greywolve greywolve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might have some conflicts with my PR that one of us will need to resolve. :P

@pantrif pantrif merged commit 7603ea5 into main Nov 19, 2024
3 checks passed
@pantrif pantrif deleted the feat/core-assignments branch November 19, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greywolve greywolve greywolve approved these changes

@bamzedev bamzedev Awaiting requested review from bamzedev

@danielvladco danielvladco Awaiting requested review from danielvladco

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pantrif @greywolve @bamzedev @danielvladco