Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize SAFROLE consensus #120

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Finalize SAFROLE consensus #120

merged 2 commits into from
Nov 19, 2024

Conversation

greywolve
Copy link
Contributor

Add UpdateSafroleState function which passes all test vectors.

Closes #70

@greywolve greywolve force-pushed the feat/finalize-safrole branch from 64166ae to 82e76f8 Compare November 18, 2024 14:51
@greywolve greywolve requested a review from a team November 18, 2024 14:52
@greywolve greywolve force-pushed the feat/finalize-safrole branch 2 times, most recently from 45acbaa to 4b5e4cd Compare November 18, 2024 15:04
@greywolve greywolve force-pushed the feat/finalize-safrole branch 4 times, most recently from 12c0a32 to 9230996 Compare November 19, 2024 10:20
internal/statetransition/state_transition.go Outdated Show resolved Hide resolved
internal/statetransition/state_transition.go Outdated Show resolved Hide resolved
internal/statetransition/state_transition.go Outdated Show resolved Hide resolved
internal/statetransition/state_transition.go Outdated Show resolved Hide resolved
internal/statetransition/state_transition.go Outdated Show resolved Hide resolved
internal/statetransition/state_transition.go Outdated Show resolved Hide resolved
internal/statetransition/state_transition.go Outdated Show resolved Hide resolved
internal/statetransition/state_transition.go Outdated Show resolved Hide resolved
internal/statetransition/state_transition.go Outdated Show resolved Hide resolved
internal/statetransition/state_transition.go Outdated Show resolved Hide resolved
Copy link
Contributor

@bamzedev bamzedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid overall! Maybe in the future we can think to reduce the complexity of the UpdateSafroleState a bit.

internal/statetransition/state_transition.go Outdated Show resolved Hide resolved
internal/statetransition/state_transition.go Outdated Show resolved Hide resolved
internal/statetransition/state_transition.go Outdated Show resolved Hide resolved
internal/statetransition/state_transition.go Outdated Show resolved Hide resolved
internal/statetransition/state_transition.go Outdated Show resolved Hide resolved
internal/statetransition/state_transition.go Outdated Show resolved Hide resolved
internal/statetransition/state_transition.go Outdated Show resolved Hide resolved
danielvladco
danielvladco previously approved these changes Nov 19, 2024
greywolve and others added 2 commits November 19, 2024 14:06
Add UpdateSafroleState function which passes all test vectors.
Co-authored-by: Emanuel Pargov <bamzedev@gmail.com>
@greywolve greywolve force-pushed the feat/finalize-safrole branch from a4f97e9 to a3d9b67 Compare November 19, 2024 13:06
@greywolve greywolve merged commit 086d5aa into main Nov 19, 2024
3 checks passed
@greywolve greywolve deleted the feat/finalize-safrole branch November 20, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Safrole consensus
3 participants