-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finalize SAFROLE consensus #120
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greywolve
force-pushed
the
feat/finalize-safrole
branch
from
November 18, 2024 14:51
64166ae
to
82e76f8
Compare
greywolve
force-pushed
the
feat/finalize-safrole
branch
2 times, most recently
from
November 18, 2024 15:04
45acbaa
to
4b5e4cd
Compare
bamzedev
reviewed
Nov 18, 2024
greywolve
force-pushed
the
feat/finalize-safrole
branch
4 times, most recently
from
November 19, 2024 10:20
12c0a32
to
9230996
Compare
bamzedev
reviewed
Nov 19, 2024
bamzedev
reviewed
Nov 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solid overall! Maybe in the future we can think to reduce the complexity of the UpdateSafroleState
a bit.
danielvladco
previously approved these changes
Nov 19, 2024
greywolve
force-pushed
the
feat/finalize-safrole
branch
from
November 19, 2024 12:57
bd1791f
to
a4f97e9
Compare
bamzedev
approved these changes
Nov 19, 2024
Add UpdateSafroleState function which passes all test vectors.
Co-authored-by: Emanuel Pargov <bamzedev@gmail.com>
greywolve
force-pushed
the
feat/finalize-safrole
branch
from
November 19, 2024 13:06
a4f97e9
to
a3d9b67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add UpdateSafroleState function which passes all test vectors.
Closes #70