Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't Save Images From More than 180 Tabs (1 image per tab) #349

Open
brazenvoid opened this issue Jul 19, 2024 · 6 comments
Open

Can't Save Images From More than 180 Tabs (1 image per tab) #349

brazenvoid opened this issue Jul 19, 2024 · 6 comments
Labels

Comments

@brazenvoid
Copy link

Simply the extension experiences an irrecoverable crash when attempting to save more than ~180 images from 180 tabs.

It does not show any error.

It downloads them in the extension page just fine.

To recover I have to force an extension reload through enable/disable cycle in Firefox.

There is another odd behaviour with such. If for example I initiate the action of picking all the images, any cancellation and initiation for a subset does not work. It always resumes the picking for the whole group.

Expected behavior
It downloads all images, regardless of how many.

Environments (please complete the following information):

  • OS: Windows 10
  • Browser: Firefox 128
  • Extension Version: 0.17.0
@brazenvoid brazenvoid added the bug label Jul 19, 2024
@eight04
Copy link
Owner

eight04 commented Jul 19, 2024

Maybe it's an out of memory crash.

Could you see any memory spike in task manager after clicking the "save" button?

@brazenvoid
Copy link
Author

No change in memory use.

Also I forgot to mention, not a single image actually gets saved and if the option close tabs is checked, some ~70 don't get closed.

Very rarely it does throw an unexpected error confirm box and in this case the picka tab remains on screen though it does nothing.

@brazenvoid
Copy link
Author

And another thing, I think something changed in Firefox as it did work for as many images as I tried with it before.

@eight04
Copy link
Owner

eight04 commented Jul 19, 2024

Sounds like it failed before downloading the image.

Do you have any special tab opened? Like system UI, extension pages, etc.

@brazenvoid
Copy link
Author

No, no system tab open.

The UI does show all the thumbnails, doesn't that mean they were downloaded already? But yes it doesn't make sense, the memory doesn't go up at all.

@eight04
Copy link
Owner

eight04 commented Jul 19, 2024

Since the picker remains opened, are you able to see any error in F12 console after clicking the save button?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants