-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't Save Images From More than 180 Tabs (1 image per tab) #349
Comments
Maybe it's an out of memory crash. Could you see any memory spike in task manager after clicking the "save" button? |
No change in memory use. Also I forgot to mention, not a single image actually gets saved and if the option close tabs is checked, some ~70 don't get closed. Very rarely it does throw an unexpected error confirm box and in this case the picka tab remains on screen though it does nothing. |
And another thing, I think something changed in Firefox as it did work for as many images as I tried with it before. |
Sounds like it failed before downloading the image. Do you have any special tab opened? Like system UI, extension pages, etc. |
No, no system tab open. The UI does show all the thumbnails, doesn't that mean they were downloaded already? But yes it doesn't make sense, the memory doesn't go up at all. |
Since the picker remains opened, are you able to see any error in F12 console after clicking the save button? |
Simply the extension experiences an irrecoverable crash when attempting to save more than ~180 images from 180 tabs.
It does not show any error.
It downloads them in the extension page just fine.
To recover I have to force an extension reload through enable/disable cycle in Firefox.
There is another odd behaviour with such. If for example I initiate the action of picking all the images, any cancellation and initiation for a subset does not work. It always resumes the picking for the whole group.
Expected behavior
It downloads all images, regardless of how many.
Environments (please complete the following information):
The text was updated successfully, but these errors were encountered: