Translating date

[Pafzedog]

Hi,

it would be nice if date (Created, published on, etc ...) could be translated too.

thanks

[eikek]

Ah yes, you're right. I totally forgot about these dates.

[eikek]

Hi @Pafzedog , so I just had some time to look into this. Fortunately one library in use, ryannhg/date-format, already had translations for French, which I took. But this only applies to the date components, like month name and weekday name. The date pattern is left as is, because (sadly) I don't know French…. So … could you maybe have a look at this? It is in Messages/DateFormat.elm, the format part. This defines how the date-time string looks like.

[Pafzedog]

ok, for french language we have to put day name before month name, I think also that comma between month and year is not needed and replacing comma after day of week by a dot is more "in the rules" of the language for an abbreviation.

Something like this

{ format =
        [ DateFormat.dayOfWeekNameAbbreviated
        , DateFormat.text ". "
        , DateFormat.dayOfMonthSuffix
        , DateFormat.text " "
        , DateFormat.monthNameFull
        , DateFormat.text " "
        , DateFormat.yearNumber
        , DateFormat.text ", "
        , DateFormat.hourMilitaryNumber
        , DateFormat.text ":"
        , DateFormat.minuteFixed
        ]
    , lang = french
    }

[eikek]

Thank you! It would look like this:

Does this look ok?

[Pafzedog]

After a better look to french translation in this library, I think I don't agree with the author about dayOfMonthSuffix.
In french, only the first day of the month need the suffix "er", all the others are just left as it.
It seems that the dev add "e" as suffix for all the other days.
I opened an issue

[Pafzedog]

Thank you! It would look like this:

Does this look ok?

It is far better than before but this "e" suffix look weird.
PS: sorry but we wrote at the same time ;)

[eikek]

Ah ok, thanks! Good is, we can just change it in sharry.

So, if I understand correctly, it should read like this:

toFrenchOrdinalSuffix : Int -> String
toFrenchOrdinalSuffix n =
    if n == 1 then
        "er"

    else
        ""

?

Do you maybe want to do this change? (so I don't take credit that is not mine) But I can change this, of course, if you want.

[Pafzedog]

It's perfect like that.
If you can make the change, I don't really care about fatherhood and, to tell you the truth, I think it would take me hours to get my git repository up and running again. XD

[eikek]

Sure :-) Thank you a lot!