2024-09-05 Update #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bring the french disassembly up to date with pret/pokered as of September 5 2024 Use long option flags for rgbgfx, same as tools/gfx Fix comment about auto text box drawing (#458) Actually, setting bit 0 of this byte disables auto text box drawing on calling DisplayTextID. See https://github.com/pret/pokered/blob/6e3ab0a9e97ff14123ac65f56cb4b4ddab45b695/engine/menus/display_text_id_init.asm#L7 Use bankless symbols for VC constants This is valid according to the .sym file spec: <https://rgbds.gbdev.io/sym/> Identify wcf91 as wCurPartySpecies, wCurItem, and wCurListMenuItem (#457) Identify wcd6d as wNameBuffer and others (#455) Identify various flag labels and bit constants (#454) Build with RGBDS 0.8.0, though it is not yet required Identify some unused WRAM variables (#453) Add comment about audio engine perfect pitch bug (#451) Use constant in wram for hidden item flags (#445) Prevents defining more hidden items than the flag array has room for Fix hard-coded bank Co-Authored-By: dannye <33dannye@gmail.com> Co-Authored-By: Vortyne <104168801+vortyne@users.noreply.github.com> Co-Authored-By: Preeyan Parmar <4997904+preeyan@users.noreply.github.com> Co-Authored-By: Sylvie <35663410+rangi42@users.noreply.github.com>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring the french disassembly up to date with pret/pokered as of September 5 2024