Cleanup/dont use eisbuk in app #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Create the componenent in 'client' package (as a single source of truth for the app layout * Use the controller on each page (passing in only the page-specific content) instead of the 'Layout' from the UI
…ent (instead of a component) * Use EisbukAvatar in stories, but not in production
…ame' and add it to the organization
* Update '/debug' page to create organization with default display name ("EisBuk Dev")
* LayoutContent is scrollable 'main' element * This allows us to render the CalendarNav outside the scrollable container (i.e. keep it fixed as we scroll) * LayoutContent also applies 'content-container' by default (use 'wide=true' to override) * Apply said updates to all pages in the client app
ikusteu
force-pushed
the
cleanup/dont-use-eisbuk-in-app
branch
from
345a3f8
to
7ce5076
Compare
silviot
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #774
Additionally: