Some copy/paste related fixes: #810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikusteu
force-pushed
the
fix/copy-paste-bug
branch
from
dc0020a
to
51b84ad
Compare
* In firestore compat `doc` function, client variant: if doc path is not provided (we wish a new server-assigned id), pass only the parent node (to prevent empty path crashes) * In firestore compat `batch` function, bind `this` to returned `commit` methods (for both client and server variant)
ikusteu
force-pushed
the
fix/copy-paste-bug
branch
from
51b84ad
to
4a12a2d
Compare
silviot
reviewed
Sep 11, 2023
silviot
approved these changes
Sep 11, 2023
silviot
force-pushed
the
fix/copy-paste-bug
branch
from
f2b84fa
to
478c917
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docfunction, client variant: if doc path is not provided (we wish a new server-assigned id), pass only the parent node (to prevent empty path crashes)batchfunction, bindthisto returnedcommitmethods (for both client and server variant)Fixes #797