Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update github actions to use node20 compatible versions #953

Merged
merged 1 commit into from
May 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions .github/workflow.templates/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
timeout-minutes: 10
steps:
- #@ checkout()
- uses: actions/setup-node@v3
- uses: actions/setup-node@v4
with:
node-version: "18"
- #@ cache_node()
Expand Down Expand Up @@ -91,7 +91,7 @@ jobs:
timeout-minutes: 10
steps:
- #@ checkout()
- uses: actions/setup-node@v3
- uses: actions/setup-node@v4
with:
node-version: "18"
- #@ cache_node()
Expand All @@ -113,7 +113,7 @@ jobs:
path: packages/client/junit.xml
reporter: java-junit
- name: Coveralls
uses: coverallsapp/github-action@master
uses: coverallsapp/github-action@v2
if: steps.has_secret.outputs.HAS_SECRETS
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
Expand All @@ -139,7 +139,7 @@ jobs:
timeout-minutes: 10
steps:
- #@ checkout()
- uses: actions/setup-node@v3
- uses: actions/setup-node@v4
with:
node-version: "18"
- #@ cache_node()
Expand All @@ -155,7 +155,7 @@ jobs:
runs-on: ubuntu-20.04
steps:
- #@ checkout()
- uses: actions/setup-node@v3
- uses: actions/setup-node@v4
with:
node-version: "18"
- #@ cache_cypress()
Expand All @@ -165,7 +165,7 @@ jobs:
- name: Build app
run: cd packages/client && NODE_OPTIONS="--max-old-space-size=8192" rushx build:test
- name: Cypress run
uses: cypress-io/github-action@v5
uses: cypress-io/github-action@v6
with:
start: emulators-start
browser: chrome
Expand All @@ -191,7 +191,7 @@ jobs:

- #@ check_secrets()
- name: Coveralls
uses: coverallsapp/github-action@master
uses: coverallsapp/github-action@v2
if: steps.has_secret.outputs.HAS_SECRETS
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
Expand Down Expand Up @@ -224,7 +224,7 @@ jobs:
steps:
- #@ check_secrets()
- name: Finalize Coveralls
uses: coverallsapp/github-action@master
uses: coverallsapp/github-action@v2
if: steps.has_secret.outputs.HAS_SECRETS
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
Expand All @@ -236,7 +236,7 @@ jobs:
timeout-minutes: 10
steps:
- #@ checkout()
- uses: actions/setup-node@v3
- uses: actions/setup-node@v4
with:
node-version: "18"
- #@ cache_node()
Expand Down
4 changes: 2 additions & 2 deletions .github/workflow.templates/cache.lib.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#@ def cache_node():
name: Cache node modules and firebase emulators
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: |
~/.rush
Expand All @@ -13,7 +13,7 @@ with:

#@ def cache_cypress():
name: Cache node modules, firebase emulators and cypress
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: |
~/.rush
Expand Down
6 changes: 3 additions & 3 deletions .github/workflow.templates/cypress-matrix.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
dummy2: [1, 2, 3, 4, 5, 6]
steps:
- #@ checkout()
- uses: actions/setup-node@v3
- uses: actions/setup-node@v4
with:
node-version: "18"
- #@ cache_cypress()
Expand All @@ -41,7 +41,7 @@ jobs:
- name: Build app
run: cd packages/client && NODE_OPTIONS="--max-old-space-size=8192" rushx build:test
- name: Cypress run
uses: cypress-io/github-action@v4
uses: cypress-io/github-action@v6
with:
start: emulators-start
#! We're using our own instalation as it is, so just skipping this part
Expand All @@ -52,7 +52,7 @@ jobs:
config-file: cypress-ci.config.ts
- #@ check_secrets()
- name: Coveralls
uses: coverallsapp/github-action@master
uses: coverallsapp/github-action@v2
if: steps.has_secret.outputs.HAS_SECRETS
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflow.templates/deploy-production.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
- name: Install expect
run: sudo apt-get -y install expect
- #@ checkout()
- uses: actions/setup-node@v3
- uses: actions/setup-node@v4
with:
node-version: "18"
- #@ cache_node()
Expand Down
2 changes: 1 addition & 1 deletion .github/workflow.templates/pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Check if PRs are dirty
uses: eps1lon/actions-label-merge-conflict@releases/2.x
uses: eps1lon/actions-label-merge-conflict@v3
if: env.LABELING_TOKEN != '' && env.LABELING_TOKEN != null
id: check
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflow.templates/setup.lib.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#@ def checkout(fetchdepth=1):
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
submodules: "recursive"
fetch-depth: #@ fetchdepth
Expand Down
2 changes: 1 addition & 1 deletion .github/workflow.templates/storybook.lib.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ runs-on: ubuntu-latest
timeout-minutes: 10
steps:
- #@ checkout(0)
- uses: actions/setup-node@v3
- uses: actions/setup-node@v4
with:
node-version: "18"
- #@ cache_node()
Expand Down
2 changes: 1 addition & 1 deletion .github/workflow.templates/vitest-matrix.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
dummy2: [1, 2, 3, 4, 5, 6]
steps:
- #@ checkout()
- uses: actions/setup-node@v2
- uses: actions/setup-node@v4
with:
node-version: "18"
- #@ cache_node()
Expand Down
50 changes: 25 additions & 25 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,15 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 10
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
submodules: recursive
fetch-depth: 1
- uses: actions/setup-node@v3
- uses: actions/setup-node@v4
with:
node-version: "18"
- name: Cache node modules and firebase emulators
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: |
~/.rush
Expand Down Expand Up @@ -96,15 +96,15 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 10
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
submodules: recursive
fetch-depth: 1
- uses: actions/setup-node@v3
- uses: actions/setup-node@v4
with:
node-version: "18"
- name: Cache node modules and firebase emulators
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: |
~/.rush
Expand Down Expand Up @@ -133,7 +133,7 @@ jobs:
path: packages/client/junit.xml
reporter: java-junit
- name: Coveralls
uses: coverallsapp/github-action@master
uses: coverallsapp/github-action@v2
if: steps.has_secret.outputs.HAS_SECRETS
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
Expand Down Expand Up @@ -175,15 +175,15 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 10
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
submodules: recursive
fetch-depth: 1
- uses: actions/setup-node@v3
- uses: actions/setup-node@v4
with:
node-version: "18"
- name: Cache node modules and firebase emulators
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: |
~/.rush
Expand All @@ -206,15 +206,15 @@ jobs:
name: Cypress browser tests
runs-on: ubuntu-20.04
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
submodules: recursive
fetch-depth: 1
- uses: actions/setup-node@v3
- uses: actions/setup-node@v4
with:
node-version: "18"
- name: Cache node modules, firebase emulators and cypress
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: |
~/.rush
Expand All @@ -233,7 +233,7 @@ jobs:
- name: Build app
run: cd packages/client && NODE_OPTIONS="--max-old-space-size=8192" rushx build:test
- name: Cypress run
uses: cypress-io/github-action@v5
uses: cypress-io/github-action@v6
with:
start: emulators-start
browser: chrome
Expand All @@ -250,7 +250,7 @@ jobs:
if: success() || failure()
run: '[ "${{ secrets.CYPRESS_KEY }}" != "" ] && echo HAS_SECRETS=true >> $GITHUB_OUTPUT || echo HAS_SECRETS= >> $GITHUB_OUTPUT'
- name: Coveralls
uses: coverallsapp/github-action@master
uses: coverallsapp/github-action@v2
if: steps.has_secret.outputs.HAS_SECRETS
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
Expand Down Expand Up @@ -304,7 +304,7 @@ jobs:
if: success() || failure()
run: '[ "${{ secrets.CYPRESS_KEY }}" != "" ] && echo HAS_SECRETS=true >> $GITHUB_OUTPUT || echo HAS_SECRETS= >> $GITHUB_OUTPUT'
- name: Finalize Coveralls
uses: coverallsapp/github-action@master
uses: coverallsapp/github-action@v2
if: steps.has_secret.outputs.HAS_SECRETS
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
Expand All @@ -314,15 +314,15 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 10
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
submodules: recursive
fetch-depth: 1
- uses: actions/setup-node@v3
- uses: actions/setup-node@v4
with:
node-version: "18"
- name: Cache node modules and firebase emulators
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: |
~/.rush
Expand All @@ -342,15 +342,15 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 10
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
submodules: recursive
fetch-depth: 0
- uses: actions/setup-node@v3
- uses: actions/setup-node@v4
with:
node-version: "18"
- name: Cache node modules and firebase emulators
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: |
~/.rush
Expand Down Expand Up @@ -405,15 +405,15 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 10
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
submodules: recursive
fetch-depth: 0
- uses: actions/setup-node@v3
- uses: actions/setup-node@v4
with:
node-version: "18"
- name: Cache node modules and firebase emulators
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: |
~/.rush
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/cypress-matrix.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,15 +27,15 @@ jobs:
- 5
- 6
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
submodules: recursive
fetch-depth: 1
- uses: actions/setup-node@v3
- uses: actions/setup-node@v4
with:
node-version: "18"
- name: Cache node modules, firebase emulators and cypress
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: |
~/.rush
Expand All @@ -54,7 +54,7 @@ jobs:
- name: Build app
run: cd packages/client && NODE_OPTIONS="--max-old-space-size=8192" rushx build:test
- name: Cypress run
uses: cypress-io/github-action@v4
uses: cypress-io/github-action@v6
with:
start: emulators-start
install: false
Expand All @@ -67,7 +67,7 @@ jobs:
if: success() || failure()
run: '[ "${{ secrets.CYPRESS_KEY }}" != "" ] && echo HAS_SECRETS=true >> $GITHUB_OUTPUT || echo HAS_SECRETS= >> $GITHUB_OUTPUT'
- name: Coveralls
uses: coverallsapp/github-action@master
uses: coverallsapp/github-action@v2
if: steps.has_secret.outputs.HAS_SECRETS
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/deploy-production.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,15 @@ jobs:
steps:
- name: Install expect
run: sudo apt-get -y install expect
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
submodules: recursive
fetch-depth: 1
- uses: actions/setup-node@v3
- uses: actions/setup-node@v4
with:
node-version: "18"
- name: Cache node modules and firebase emulators
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: |
~/.rush
Expand Down
Loading