Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct commit range for GitHub Actions #10

Merged
merged 2 commits into from
Dec 31, 2024

Conversation

Ao-senXiong
Copy link

#9 Fixes the CI_ORG but not the commit range.

The variable need to be set correctly by adding prefix for Github CI. For example for EISOP#862,

Branches in Github CI is

echo   remotes/origin/master
echo   remotes/pull/862/merge

We should use the following env variable to set them.

GITHUB_BASE_REF=master
GITHUB_REF_NAME=862/merge

@Ao-senXiong Ao-senXiong requested a review from wmdietl December 31, 2024 21:52
@wmdietl wmdietl changed the title Use correct commit range for github actions Use correct commit range for GitHub Actions Dec 31, 2024
Copy link
Member

@wmdietl wmdietl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks reasonable.

In eisop/checker-framework#862 you could temporarily check out a branch of this project to make sure it correctly works.

@wmdietl wmdietl merged commit 9787b17 into eisop-plume-lib:master Dec 31, 2024
@Ao-senXiong Ao-senXiong deleted the use-correct-commit-range branch December 31, 2024 22:17
@Ao-senXiong
Copy link
Author

you could temporarily check out a branch of this project to make sure it correctly works.

Oh, you mean in the test script?

@wmdietl
Copy link
Member

wmdietl commented Jan 2, 2025

you could temporarily check out a branch of this project to make sure it correctly works.

Oh, you mean in the test script?

In whichever script that clones this repository, you can change it to clone your own branch of this repository. Then you can experiment with changes more quickly. Things seem to work now, but maybe in the future this would be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants