Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Javadoc to qualifers for viewpoint test checker #1021

Merged
merged 4 commits into from
Dec 22, 2024

Conversation

Ao-senXiong
Copy link
Member

Not sure why but this causes misc check failure for #1013. Maybe it is because PICO also have @Bottom qualifier.

Copy link
Member

@wmdietl wmdietl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't object, but the CI failure I see in #1013 is different.

I would remove the links that just go to the same class, they don't add anything. Maybe make it code? Also, make the text uniform for all of them.

@wmdietl wmdietl assigned Ao-senXiong and unassigned wmdietl Dec 20, 2024
@Ao-senXiong
Copy link
Member Author

Ao-senXiong commented Dec 20, 2024

I don't object, but the CI failure I see in #1013 is different.

I would remove the links that just go to the same class, they don't add anything. Maybe make it code? Also, make the text uniform for all of them.

It seems the error changes now. The previous failure I had before today was https://dev.azure.com/eisop/checker-framework/_build/results?buildId=6325&view=logs&jobId=4b19ccca-7d7d-5749-26de-b87349fba2b4&j=4b19ccca-7d7d-5749-26de-b87349fba2b4&t=4dba1f6c-8e7b-5172-04db-4dd554c55b12.

@Ao-senXiong Ao-senXiong requested a review from wmdietl December 21, 2024 20:01
@wmdietl wmdietl merged commit 3d43fa3 into eisop:master Dec 22, 2024
73 of 74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants