Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Javadoc links #1040

Merged
merged 8 commits into from
Jan 3, 2025
Merged

Fix Javadoc links #1040

merged 8 commits into from
Jan 3, 2025

Conversation

Ao-senXiong
Copy link
Member

No description provided.

@Ao-senXiong Ao-senXiong requested a review from wmdietl January 2, 2025 19:25
@wmdietl wmdietl changed the title Fixes Javadoc link Fix Javadoc links Jan 2, 2025
wmdietl
wmdietl approved these changes Jan 2, 2025
View reviewed changes
Copy link
Member

@wmdietl wmdietl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's use a qualified name instead of an import that is only used for javadoc.

framework/src/main/java/org/checkerframework/framework/type/AnnotatedTypeMirror.java Outdated Show resolved Hide resolved
framework/src/main/java/org/checkerframework/framework/type/AnnotatedTypeMirror.java Outdated Show resolved Hide resolved
@wmdietl wmdietl assigned Ao-senXiong and unassigned wmdietl Jan 2, 2025
@Ao-senXiong Ao-senXiong requested a review from wmdietl January 2, 2025 23:35
@Ao-senXiong Ao-senXiong assigned wmdietl and unassigned Ao-senXiong Jan 2, 2025
@Ao-senXiong Ao-senXiong mentioned this pull request Jan 2, 2025
Merged
wmdietl
wmdietl approved these changes Jan 3, 2025
View reviewed changes
Copy link
Member

@wmdietl wmdietl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tracking down this problem!

@wmdietl wmdietl merged commit 68a6360 into eisop:master Jan 3, 2025
65 checks passed
@Ao-senXiong Ao-senXiong deleted the javadoc-fix branch January 3, 2025 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wmdietl wmdietl wmdietl approved these changes

Assignees

@wmdietl wmdietl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ao-senXiong @wmdietl