-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI test for the templatefora-checker
#1048
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI doesn't pass, looks like the project is cloned in the wrong location.
@wmdietl This PR dependens on jdk23 and should be merged after eisop/templatefora-checker#2 |
The error looks more like some problem with what git repository is cloned. But I've merged eisop/templatefora-checker#2 now. |
There still seems to be some git issue, see here. |
Co-authored-by: Werner Dietl <wdietl@gmail.com>
I think the pull error is expected as I am cloning branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
executable 'git' | ||
args = [ | ||
'pull', | ||
'https://github.com/eisop/templatefora-checker.git' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding this comment:
In CI we are cloning something from the PR authors org/branch and then here we're trying to pull in the eisop version. I don't think that is correct.
We should do what we do in the createCloneTask
in build.gradle
: simply pull if the directory already exists.
Can you open a separate PR that reduces the duplication between the demos and template tasks by reusing the createCloneTask
(or extracting some of its logic) and then using that here.
templatefora-checker
Merge with eisop/templatefora-checker#1