Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI test for the templatefora-checker #1048

Merged
merged 5 commits into from
Jan 6, 2025

Conversation

Ao-senXiong
Copy link
Member

@Ao-senXiong Ao-senXiong commented Jan 5, 2025

Copy link
Member

@wmdietl wmdietl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI doesn't pass, looks like the project is cloned in the wrong location.

@Ao-senXiong
Copy link
Member Author

CI doesn't pass, looks like the project is cloned in the wrong location.

@wmdietl This PR dependens on jdk23 and should be merged after eisop/templatefora-checker#2

@wmdietl
Copy link
Member

wmdietl commented Jan 5, 2025

CI doesn't pass, looks like the project is cloned in the wrong location.

@wmdietl This PR dependens on jdk23 and should be merged after eisop/templatefora-checker#2

The error looks more like some problem with what git repository is cloned. But I've merged eisop/templatefora-checker#2 now.

@wmdietl
Copy link
Member

wmdietl commented Jan 5, 2025

There still seems to be some git issue, see here.
No similar output is made for the demos task.

checker/build.gradle Outdated Show resolved Hide resolved
Co-authored-by: Werner Dietl <wdietl@gmail.com>
@Ao-senXiong
Copy link
Member Author

There still seems to be some git issue, see here. No similar output is made for the demos task.

I think the pull error is expected as I am cloning branch use-eisop-dependency for templatefora checker and pull the original branch. After we merge both PRs, it would be fine.

@Ao-senXiong Ao-senXiong requested a review from wmdietl January 6, 2025 02:37
@Ao-senXiong Ao-senXiong assigned wmdietl and unassigned Ao-senXiong Jan 6, 2025
Copy link
Member

@wmdietl wmdietl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

checker/build.gradle Outdated Show resolved Hide resolved
executable 'git'
args = [
'pull',
'https://github.com/eisop/templatefora-checker.git'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding this comment:
In CI we are cloning something from the PR authors org/branch and then here we're trying to pull in the eisop version. I don't think that is correct.

We should do what we do in the createCloneTask in build.gradle: simply pull if the directory already exists.
Can you open a separate PR that reduces the duplication between the demos and template tasks by reusing the createCloneTask (or extracting some of its logic) and then using that here.

checker/build.gradle Outdated Show resolved Hide resolved
@wmdietl wmdietl changed the title Add downstream task templatefora-checker Add CI test for the templatefora-checker Jan 6, 2025
@wmdietl wmdietl enabled auto-merge (squash) January 6, 2025 20:30
@wmdietl wmdietl merged commit f70c3f9 into eisop:master Jan 6, 2025
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants