Use createCloneTask for templateTest and demoTest #1052
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmdietl
requested changes
Jan 7, 2025
checker/build.gradle
Outdated
| ignoreExitValue = true | ||
| } | ||
| } | ||
| createCloneTask('getDemos', 'https://github.com/eisop/checker-framework.demos.git', demosDir) |
There was a problem hiding this comment.
This creates a clone task, but nothing is executing that task.
Create a fresh clone of the repository, change to this PR, and execute ./gradlew templateTests.
You'll get:
* What went wrong:
Execution failed for task ':checker:templateTests'.
> A problem occurred starting process 'command './gradlew''
CI passes, because it clones the directory already beforehand.
There was a problem hiding this comment.
Thanks. I have moved the create clone tasks to root directory along with other clone tasks. Now it should works.
wmdietl
requested changes
Jan 7, 2025
| ] | ||
| ignoreExitValue = true | ||
| } | ||
| injected.execOps.exec { |
There was a problem hiding this comment.
I don't think exec-ing another task is ideal. Shouldn't it just be listed in dependsOn?
There was a problem hiding this comment.
Yeah, I think we can move this it to dependson like dependsOn: ['assembleForJavac', ':getDemos']
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1051