Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix intersection of wildcards with extends bounds #1066

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

wmdietl
Copy link
Member

@wmdietl wmdietl commented Jan 21, 2025

No description provided.

@wmdietl
Copy link
Member Author

wmdietl commented Jan 21, 2025

These changes and tests are inspired by the failure of https://github.com/jspecify/jspecify/blob/samples-google-prototype-eisop/samples/CaptureConvertedTypeVariableBounded.java in the JSpecify reference checker. The problem applies to all type systems and needs to be fixed in the framework.

There is still a problem with override checks, see downstream failure of the JSpecify reference checker with:

      Issue164More.java:28: error: (override.param.invalid)

There are other CI tests failing.

I'll also fix these errors in this PR and improve test coverage.

@wmdietl wmdietl marked this pull request as draft January 21, 2025 01:33
@wmdietl wmdietl marked this pull request as ready for review January 22, 2025 02:14
@Ao-senXiong
Copy link
Member

I will try to understand the issue first and review tomorrow.

Copy link
Member

@Ao-senXiong Ao-senXiong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants