Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Class literals default and add class literal node in CFG #550

Open
wants to merge 50 commits into
base: master
Choose a base branch
from
Open

Fix Class literals default and add class literal node in CFG #550

wants to merge 50 commits into from

Conversation

Ao-senXiong
Copy link
Member

@Ao-senXiong Ao-senXiong commented Aug 4, 2023 •
edited by wmdietl
Loading

Fixes #548.

@Ao-senXiong Ao-senXiong marked this pull request as draft August 4, 2023 01:10
wmdietl
wmdietl requested changes Aug 8, 2023
View reviewed changes
Copy link
Member

@wmdietl wmdietl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting on this!

checker/src/main/java/org/checkerframework/checker/nullness/NullnessTransfer.java Outdated Show resolved Hide resolved
framework/src/main/java/org/checkerframework/common/basetype/BaseTypeVisitor.java Outdated Show resolved Hide resolved
checker/tests/nullness/Issue3020.java Outdated Show resolved Hide resolved
@wmdietl
Copy link
Member

wmdietl commented Aug 8, 2023

#548

You need to say something like Fixes #548 for GitHub to make the connection to the issue.

@Ao-senXiong Ao-senXiong mentioned this pull request Aug 9, 2023
Merged
@Ao-senXiong Ao-senXiong marked this pull request as ready for review October 16, 2023 05:21
@Ao-senXiong
Javadoc for NodeVisitor
fcd6950
@Ao-senXiong
Update expected CFG
e6b6177
@Ao-senXiong
A lot of Javadoc
c89b017
@Ao-senXiong
Maybe this is the cause of daikon failure
4d04987
@Ao-senXiong
Revert the change
9fee97c
@Ao-senXiong
Fix broken link
ea6b44e
@Ao-senXiong
Don't check Daikon 2 to see if there is other failure
a59417e
@Ao-senXiong
Undo CI
5a15cd4
@Ao-senXiong
Use PrimitiveTypeNode to represent class literal
47b2f63
@Ao-senXiong
Remove extra comma
b7c80f1
@Ao-senXiong
Use dummy constructor parameter to prevent ClassCastException
f5dec68
@Ao-senXiong
Change field tree to Tree type
ac88eef
@Ao-senXiong
Only handle class literal
731e05e
@Ao-senXiong
PrimitiveTypeNode Javadoc
076d3d3
@Ao-senXiong
Handle class literal seperately
691d206
@Ao-senXiong
Also generate javaexpression for class literal and undo lockvisitor c…
699ffd3 
…hange
@Ao-senXiong
Don't do cast and comment out unknown condition for testing
838fa79
@Ao-senXiong
Don't run JSpecify first
e5a3cd8
@Ao-senXiong
Use ClassLiteralNode again and remove hacks
3527e17
@Ao-senXiong
Add ClassLiteral file
e3a6381
@Ao-senXiong
Don't check jspeicfy yet
86d7d43
@Ao-senXiong
Javadoc
0ec3a94
@Ao-senXiong
Javadoc
de55ec0
@Ao-senXiong
Javadoc
115ba24
@Ao-senXiong Ao-senXiong requested a review from wmdietl December 16, 2024 09:23
@Ao-senXiong Ao-senXiong assigned wmdietl and unassigned Ao-senXiong Dec 17, 2024
@Ao-senXiong Ao-senXiong changed the title Fix Class literals in field access and related type checks Fix Class literals default and add class literal node in CFG Dec 17, 2024
Ao-senXiong
Ao-senXiong commented Dec 17, 2024
View reviewed changes
javacutil/src/main/java/org/checkerframework/javacutil/TreeUtils.java
*
* @param tree a tree that might be a field access
* @return the element if tree is a field access expression (implicit or explicit); null
* otherwise
*/
// TODO: fix value for class literals and qualified this, which are not field accesses.
// TODO: fix value for qualified this, which is not field accesses.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will try to fix qualified this in another PR as this will make review easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wmdietl wmdietl Awaiting requested review from wmdietl

Requested changes must be addressed to merge this pull request.

Assignees

@wmdietl wmdietl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Class literals in CFGs and their type with conservative nullness
2 participants
@Ao-senXiong @wmdietl