PICO checker #762
PICO checker #762
Conversation
|
Let's finish reviewing and improving this in the separate repo before moving it here. |
| @@ -256,6 +256,8 @@ allprojects { | |||
| '**/returnsreceiverdelomboked/*', | |||
| '**/build/**', | |||
| '*/dist/**', | |||
| // Don't format util the error report location is fixed | |||
There was a problem hiding this comment.
All tests should be formatted properly. There is nothing special about PICO tests.
There was a problem hiding this comment.
Yes, that's the next thing we should look at in the future. I opened an issue in opprop opprop/immutability#53.
| @Retention(RetentionPolicy.RUNTIME) | ||
| @Target({ElementType.FIELD}) | ||
| @HoldsForDefaultValue | ||
| public @interface Assignable {} |
There was a problem hiding this comment.
Please add javadoc for everything (again, in the PICO repo).
There was a problem hiding this comment.
Sure, I will create a new PR to add the Javadoc.
| echo " https://github.com/eisop-plume-lib/plume-scripts/blob/master/git-authors.sed" && | ||
| echo " and remake contributors.tex after that pull request is merged." && | ||
| false) | ||
| ##!/bin/bash |
There was a problem hiding this comment.
Why are all the misc tests disabled?
There was a problem hiding this comment.
A lot of Javadoc issues and I just disabled for testing other tasks.
There was a problem hiding this comment.
@Ao-senXiong For the future: to disable the Javadoc checks, do touch SKIP-REQUIRE-JAVADOC in the top-level directory and add that file.
There was a problem hiding this comment.
Sure, thanks. I think I already had it but still get javadoc tasks errors, but nvm, let's find out why when PICO is moved here.
|
|
||
| import javax.lang.model.element.AnnotationMirror; | ||
|
|
||
| public interface ExtendedViewpointAdapter extends ViewpointAdapter { |
There was a problem hiding this comment.
We really need some documentation for what this interface is for. Is it PICO specific? Should it just be in the main interface?
I am not sure this will be easier or harder to review for PICO. I can getting PICO to eisop since ultimately we will do.