Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move misc CI checks to GitHub Actions #862

Merged
merged 38 commits into from
Jan 3, 2025

Conversation

Ao-senXiong
Copy link
Member

No description provided.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@Ao-senXiong Ao-senXiong marked this pull request as ready for review August 21, 2024 05:01
@Ao-senXiong
Copy link
Member Author

Ao-senXiong commented Aug 21, 2024

Looks like the place it go wrong is here:

2024-08-21T17:43:16.6615040Z Re-execution of diff command:
2024-08-21T17:43:16.6615806Z git --no-pager diff --exit-code master...misc-github-actions
2024-08-21T17:43:16.6618085Z fatal: ambiguous argument 'master...misc-github-actions': unknown revision or path not in the working tree.
2024-08-21T17:43:16.6619399Z Use '--' to separate paths from revisions, like this:
2024-08-21T17:43:16.6620234Z 'git <command> [<revision>...] -- [<file>...]'
2024-08-21T17:43:16.6620696Z 
2024-08-21T17:43:16.6621000Z Second re-execution of diff command:
2024-08-21T17:43:16.6622077Z git --no-pager diff --exit-code master...misc-github-actions > /tmp/tmp.tmp && cat /tmp/tmp.tmp
2024-08-21T17:43:16.6633123Z fatal: ambiguous argument 'master...misc-github-actions': unknown revision or path not in the working tree.
2024-08-21T17:43:16.6634510Z Use '--' to separate paths from revisions, like this:
2024-08-21T17:43:16.6635368Z 'git <command> [<revision>...] -- [<file>...]'
2024-08-21T17:43:16.6635834Z 
2024-08-21T17:43:16.6636304Z Endpoints of commit range (master and misc-github-actions):
2024-08-21T17:43:16.6648239Z fatal: ambiguous argument 'master': unknown revision or path not in the working tree.
2024-08-21T17:43:16.6649375Z Use '--' to separate paths from revisions, like this:
2024-08-21T17:43:16.6650207Z 'git <command> [<revision>...] -- [<file>...]'
2024-08-21T17:43:16.6663564Z fatal: ambiguous argument 'misc-github-actions': unknown revision or path not in the working tree.
2024-08-21T17:43:16.6664817Z Use '--' to separate paths from revisions, like this:
2024-08-21T17:43:16.6665710Z 'git <command> [<revision>...] -- [<file>...]'

@wmdietl
Copy link
Member

wmdietl commented Aug 21, 2024

Looks like the place it go wrong is here:

I had hoped that setting the fetch-depth to 0 would fix that problem...

ci-info sets these environment variables:

echo CI=true
echo CI_BRANCH=misc-github-actions
echo CI_BRANCH_NAME=misc-github-actions
echo CI_COMMIT_RANGE=master...misc-github-actions
echo CI_COMMIT_RANGE_END=misc-github-actions
echo CI_COMMIT_RANGE_START=master

However, the list of branches doesn't contain misc-github-actions:

echo * (HEAD detached at pull/862/merge)
...
echo   remotes/origin/master
...
echo   remotes/origin/origin/master
...
echo   remotes/pull/862/merge

It's a bit odd why it also doesn't find master.

The doc for [ci-info](https://github.com/eisop-plume-lib/plume-scripts/blob/master/ci-info) and [ci-lint-diff](https://github.com/eisop-plume-lib/plume-scripts/blob/master/ci-lint-diff) both say that it works with GitHub Actions, but maybe that is not well tested.

actions/checkout says that fetch-depth: 0 should 0 indicates all history for all branches and tags..

So it would seem that there is a problem with ci-info not determining the same branch names that git actually knows.
This doesn't make sense to me for master, but I see the mismatch between misc-github-actions and remotes/pull/862/merge.

@Ao-senXiong
Copy link
Member Author

Rerun after eisop-plume-lib/plume-scripts#10

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@Ao-senXiong Ao-senXiong requested a review from wmdietl January 1, 2025 00:18
@Ao-senXiong Ao-senXiong assigned wmdietl and unassigned Ao-senXiong Jan 1, 2025
@Ao-senXiong
Copy link
Member Author

This is strange. Previously, misc-jdk8 fails as it can not find reference to a method. A new commit fails at JDK 23 that code is not formated. However, both CI's misc-jdk21 works fine. I would like disable misc check CI for all except for JDK 21.

@wmdietl
Copy link
Member

wmdietl commented Jan 2, 2025

This is strange. Previously, misc-jdk8 fails as it can not find reference to a method. A new commit fails at JDK 23 that code is not formated. However, both CI's misc-jdk21 works fine. I would like disable misc check CI for all except for JDK 21.

I think we should first ensure that misc works the same on GitHub Actions as it did on Azure before.
Then we can separately discuss disabling misc for some platforms.
If we disable it for JDK 23 now, we're just delaying figuring out what doesn't work on that platform.

@wmdietl
Copy link
Member

wmdietl commented Jan 2, 2025

#1039 should fix the formatting mismatch. There are probably many other issues with markdown javadoc comments, I'll fix them later. #1039 should at least make the formatting consistent.

@wmdietl wmdietl assigned Ao-senXiong and unassigned wmdietl Jan 2, 2025
@Ao-senXiong Ao-senXiong mentioned this pull request Jan 2, 2025
@Ao-senXiong
Copy link
Member Author

I will update this after #1040

@wmdietl
Copy link
Member

wmdietl commented Jan 3, 2025

@wmdietl If things working correctly, should we remove those docker file from the repo?

We could re-purpose the docker images to be used by developers for easier local setup, e.g. on a Windows machine.
Let's keep the files for now.

@Ao-senXiong Ao-senXiong assigned wmdietl and unassigned Ao-senXiong Jan 3, 2025
@Ao-senXiong Ao-senXiong requested a review from wmdietl January 3, 2025 02:32
@Ao-senXiong
Copy link
Member Author

Ao-senXiong commented Jan 3, 2025

I already delete azure pipeline config but there are still azure tasks in the expected tasks. Maybe it will disappear after we merge this PR? Or is there any other clean up I need to do?

Copy link
Member

@wmdietl wmdietl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@wmdietl
Copy link
Member

wmdietl commented Jan 3, 2025

I already delete azure pipeline config but there are still azure tasks in the expected tasks. Maybe it will disappear after we merge this PR? Or is there any other clean up I need to do?

I'll adapt the project requirements after merging the PR.

@wmdietl wmdietl merged commit a5162ba into eisop:master Jan 3, 2025
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants