Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTORING]: replaced a dynamic import with a component #37

Merged
merged 6 commits into from
Dec 4, 2024

Conversation

OlgaYasn
Copy link
Collaborator

@OlgaYasn OlgaYasn commented Nov 26, 2024

Pull Request Template

✨ Title

  • [REFACTORING]: replaced a dynamic import with a component

πŸ“„ Description

I noticed an error message for this part of code loading: () => <VitalityLoader /> saying Component definition is missing display name. We decided to create a reusable Component to host the dynamic logic and use it everywhere where VitalityLoader was used.

βœ… Checklist

  • I have read and followed the Contribution Guide.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings or errors.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

πŸ”— Contextual Links (optional)

Add any relevant links to tracking tickets, previous discussions, or other resources.

πŸ“Έ Visuals (optional)

If possible, include images or videos that show the result of your changes.

πŸ” Reviewers

Please assign at least one reviewer for this PR. The PR cannot be merged until it is approved by the reviewer(s).

@OlgaYasn OlgaYasn added the WIP Work in progress label Nov 26, 2024
@helabenkhalfallah helabenkhalfallah merged commit 7028a57 into main Dec 4, 2024
1 check failed
@helabenkhalfallah helabenkhalfallah deleted the fix/NO-ISSUE/dynamic-loader branch December 4, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants