Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTORING]: deleted repeated matcher functions #50

Merged
merged 3 commits into from
Dec 23, 2024

Conversation

OlgaYasn
Copy link
Collaborator

Pull Request Template

✨ Title

[REFACTORING]: deleted repeated matcher functions

πŸ“„ Description

Please explain in detail what this PR does, why it is needed, and how it addresses a specific problem. Include any relevant context and background information.

βœ… Checklist

  • I have read and followed the Contribution Guide.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings or errors.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

πŸ”— Contextual Links (optional)

Add any relevant links to tracking tickets, previous discussions, or other resources.

πŸ“Έ Visuals (optional)

If possible, include images or videos that show the result of your changes.

πŸ” Reviewers

Please assign at least one reviewer for this PR. The PR cannot be merged until it is approved by the reviewer(s).

@OlgaYasn OlgaYasn self-assigned this Dec 18, 2024
@OlgaYasn OlgaYasn added the WIP Work in progress label Dec 18, 2024
@OlgaYasn OlgaYasn added the help wanted Extra attention is needed label Dec 19, 2024
# Conflicts:
#	src/v6y-front/src/commons/config/VitalityCommonConfig.tsx
@helabenkhalfallah helabenkhalfallah merged commit 554dc47 into main Dec 23, 2024
1 check passed
@helabenkhalfallah helabenkhalfallah deleted the fix/ISSUE-36/matcher-function branch December 23, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants