Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ec2-vpc-endpoint-connection): add tags to properties #390

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

ma3574
Copy link
Contributor

@ma3574 ma3574 commented Oct 18, 2024

  • Adds tags support for EC2VPCEndpointConnection resource
  • I see some resources in the repo use tags and others use Tags for the variable naming. I have picked tags as that seems more prevalent

@ma3574 ma3574 closed this Oct 18, 2024
@ma3574 ma3574 reopened this Oct 18, 2024
Copy link
Owner

@ekristen ekristen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

Please make the necessary corrections.

You have two options in terms of commits, either add a second commit or redo your original commit and force push your branch.

If you opt to redo your original commit, on your branch simply run git reset HEAD~1, make the struct changes, re-run your original git commit with the original message and then git push origin ec2-vpc-endpoint-connection-tags -f

Otherwise make a second commit on your branch, please refactor(ec2-vpc-endpoint-connection): switch to exported field

The reason for this is types.NewPropertiesFromStruct(r) -- it requires exported fields to dynamically setup the properties without having to manual do it. It's also necessary for the upcoming automated documentation that will auto-generate based on the struct of each resource.

resources/ec2-vpc-endpoint-connection.go Outdated Show resolved Hide resolved
resources/ec2-vpc-endpoint-connection.go Outdated Show resolved Hide resolved
@ma3574
Copy link
Contributor Author

ma3574 commented Oct 18, 2024

I'm new to go as a whole and I've learnt something new today. Thank you for using this as a teaching moment and providing a detailed response. I've made the changes and pushed up a second commit.

@ekristen
Copy link
Owner

I'm new to go as a whole and I've learnt something new today. Thank you for using this as a teaching moment and providing a detailed response. I've made the changes and pushed up a second commit.

Welcome to the wonderful world of go. Hope you stay a long time. My pleasure. Thank you for your contribution.

@ekristen ekristen merged commit 4ca430c into ekristen:main Oct 18, 2024
4 checks passed
@ekristen
Copy link
Owner

🎉 This PR is included in version 3.29.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants