Skip to content

Commit

Permalink
Automate collapsing ARN table in release notes (#2071)
Browse files Browse the repository at this point in the history
* Automate collapsing ARN table in release notes

* Apply suggestions from code review

---------

Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
  • Loading branch information
reakaleek and xrmx authored Jun 25, 2024
1 parent 8646535 commit 4ba7a0b
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 3 deletions.
9 changes: 7 additions & 2 deletions .ci/create-arn-table.sh
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ AWS_FOLDER=${AWS_FOLDER?:No aws folder provided}
ARN_FILE=".arn-file.md"

{
echo "### Elastic APM Python agent layer ARNs"
echo "<details>"
echo "<summary>Elastic APM Python agent layer ARNs</summary>"
echo ''
echo '|Region|ARN|'
echo '|------|---|'
Expand All @@ -22,4 +23,8 @@ for f in $(ls "${AWS_FOLDER}"); do
echo "|${f}|${LAYER_VERSION_ARN}|" >> "${ARN_FILE}"
done

echo '' >> "${ARN_FILE}"
{
echo ''
echo '</details>'
echo ''
} >> "${ARN_FILE}"
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -198,4 +198,4 @@ If you have commit access, the process is as follows:
1. After tests pass, Github Actions will automatically build and push the new release to PyPI.
1. Edit and publish the [draft Github release](https://github.com/elastic/apm-agent-python/releases)
created by Github Actions. Substitute the generated changelog with one hand written into the body of the
release and move the agent layer ARNs under a `<details>` block with a `summary`.
release.

0 comments on commit 4ba7a0b

Please sign in to comment.